Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-119121: Fix and test async.staggered.staggered_race #119173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2024
Merged

gh-119121: Fix and test async.staggered.staggered_race #119173

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d36cd5
gh-119121: Fix and test `async.staggered.staggered_race`
sobolevn May 19, 2024
3d7737b
Add a guard for WASI / etc
sobolevn May 19, 2024
6887349
Address review
sobolevn May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address review
  • Loading branch information
@sobolevn
sobolevn committed May 20, 2024
commit 688734987c5a71cdebda38562c71b47e0c8547dd
12 changes: 6 additions & 6 deletions Lib/test/test_asyncio/test_staggered.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ async def test_empty(self):
delay=None,
)

self.assertEqual(winner, None)
self.assertEqual(index, None)
self.assertIs(winner, None)
self.assertIs(index, None)
self.assertEqual(excs, [])

async def test_one_successful(self):
Expand Down Expand Up @@ -56,7 +56,7 @@ async def coro(index):
self.assertEqual(index, 1)
self.assertEqual(len(excs), 2)
self.assertIsInstance(excs[0], ValueError)
self.assertEqual(excs[1], None)
self.assertIs(excs[1], None)

async def test_first_timeout_second_successful(self):
async def coro(index):
Expand All @@ -76,7 +76,7 @@ async def coro(index):
self.assertEqual(index, 1)
self.assertEqual(len(excs), 2)
self.assertIsInstance(excs[0], asyncio.CancelledError)
self.assertEqual(excs[1], None)
self.assertIs(excs[1], None)

async def test_none_successful(self):
async def coro(index):
Expand All @@ -90,8 +90,8 @@ async def coro(index):
delay=None,
)

self.assertEqual(winner, None)
self.assertEqual(index, None)
self.assertIs(winner, None)
self.assertIs(index, None)
self.assertEqual(len(excs), 2)
self.assertIsInstance(excs[0], ValueError)
self.assertIsInstance(excs[1], ValueError)