Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-119391: Amend comment description of PyMapping_Items, PyMapping_Values and PyMapping_Keys #119392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2024

Conversation

eendebakpt
Copy link
Contributor

@eendebakpt eendebakpt commented May 22, 2024

Update the docstrings to reflect the current implementation.

Since this is not part of the user documentation I think we can skip the news entry.

@erlend-aasland erlend-aasland changed the title gh-119391: Update docstrings for PyMapping_Items, PyMapping_Values and PyMapping_Keys gh-119391: Amend comment description of PyMapping_Items, PyMapping_Values and PyMapping_Keys May 22, 2024
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't encourage PRs that amend comments (spelling mistakes, etc.), but since this shows up in IDEs I think it is ok to amend it. Thanks!

@erlend-aasland erlend-aasland merged commit d472b4f into python:main May 22, 2024
40 checks passed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
…ing_Values and PyMapping_Keys (python#119392)

The behaviour was changed in 0ccc0f6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants