Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-93554: add test for quickening of code in loops ending with conditional statement #119485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 29, 2024
Merged

gh-93554: add test for quickening of code in loops ending with conditional statement #119485

merged 2 commits into from
May 29, 2024

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented May 24, 2024 •
edited by bedevere-app bot
Loading

@iritkatriel iritkatriel added tests Tests in the Lib/test dir interpreter-core (Objects, Python, Grammar, and Parser dirs) labels May 24, 2024
@bedevere-app bedevere-app bot mentioned this pull request May 24, 2024
Closed
@iritkatriel iritkatriel requested a review from brandtbucher May 24, 2024 00:48
markshannon
markshannon approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests look good.

We should move the specialization tests to their own module, but that can be in another PR.

@iritkatriel iritkatriel merged commit 016a46a into python:main May 29, 2024
34 checks passed
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@iritkatriel @noahbkim
pythongh-93554: add test for quickening of code in loops ending with …
64cde4e 
…conditional statement (python#119485)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@iritkatriel @estyxx
pythongh-93554: add test for quickening of code in loops ending with …
8ee9841 
…conditional statement (python#119485)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon markshannon approved these changes

@brandtbucher brandtbucher Awaiting requested review from brandtbucher

Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conditional backward edges should help "warm up" code
2 participants
@iritkatriel @markshannon