Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-36053 fix pkgutil.walk_packages #11956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

bpo-36053 fix pkgutil.walk_packages #11956

wants to merge 2 commits into from

Conversation

ekiro
Copy link

@ekiro ekiro commented Feb 20, 2019 •
edited by bedevere-bot
Loading

When walk_packages encounter a package with a name that is available in sys.path, it will abandon the current package, and start walking the package from the sys.path.

Consider this file layout:

PYTHONPATH/
├──package1/
|   ├──core   
|   |   ├──some_package/
|   |   |   ├──__init__.py
|   |   |   └──mod.py
|   |   └──__init__.py
|   └──__init__.py
└──some_package/
   |   ├──__init__.py
   |   └──another_mod.py
   └──__init__.py

The result of walking package1 will be:

>> pkgutil.walk_packages('PYTHONPATH/package1')

ModuleInfo(module_finder=FileFinder('PYTHONPATH/package1/core'), name='some_package', ispkg=True)
ModuleInfo(module_finder=FileFinder('PYTHONPATH/some_package), name='another_mod', ispkg=False)

I'm not sure if it is a security issue, but it definitely should not jump off the given path.

https://bugs.python.org/issue36053

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@ekiro ekiro force-pushed the bpo-36053 branch 2 times, most recently from 236d8a9 to 20a42cd Compare February 20, 2019 17:03
taleinat
taleinat reviewed Jun 7, 2019
View reviewed changes
ekiro added 2 commits June 11, 2019 08:02
@ekiro
bpo-36053 fix pkgutil.walk_packages
cafea0a 
pkgutil.walk_packages jumps out from given path if there is
package with the same name in sys.path
@ekiro
bpo-36053 fix tests cleanup
0e61923
@csabella csabella requested a review from brettcannon November 16, 2019 02:28
@brettcannon brettcannon removed their request for review November 18, 2019 18:59
@brettcannon
Copy link
Member

@csabella I have long-term plans to remove pkgutil, so I'm removing myself from the review list.

@taleinat
Copy link
Contributor

@ncoghlan, since you commented on the bpo issue, would you like to take a look at this?

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taleinat taleinat taleinat left review comments

@auvipy auvipy auvipy approved these changes

Assignees
No one assigned
Labels
awaiting core review stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ekiro @the-knights-who-say-ni @brettcannon @taleinat @auvipy @ezio-melotti @bedevere-bot