gh-120346: Respect PYTHON_BASIC_REPL when running in interactive inspect mode #120349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no easy way to drive the new REPL via subprocess (at least for now) due to the tty requirements, so adding a test for this is much harder than the value it gives us. |
lysnikolaou
approved these changes
Jun 11, 2024
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 11, 2024
…e inspect mode (pythonGH-120349) (cherry picked from commit ec3af29) Co-authored-by: Pablo Galindo Salgado <[email protected]>
|
GH-120351 is a backport of this pull request to the 3.13 branch. |
lysnikolaou
pushed a commit
that referenced
this pull request
Jun 11, 2024
…ve inspect mode (GH-120349) (#120351) (cherry picked from commit ec3af29) Co-authored-by: Pablo Galindo Salgado <[email protected]>
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.