Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-120373: Mark test_audit.test_http as requiring the network resource #120374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2024
Merged

gh-120373: Mark test_audit.test_http as requiring the network resource #120374

merged 1 commit into from
Jun 24, 2024

Conversation

itamaro
Copy link
Contributor

@itamaro itamaro commented Jun 11, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Jun 11, 2024
@bedevere-app bedevere-app bot mentioned this pull request Jun 11, 2024
Closed
facebook-github-bot pushed a commit to facebookincubator/cinder that referenced this pull request Jun 19, 2024
@itamaro @facebook-github-bot
Patch test_audit.test_http to require 'network' resource
61181f3 
Summary:
see upstream issue: python/cpython#120373
and upstream PR: python/cpython#120374

Reviewed By: mpage

Differential Revision: D58622163

fbshipit-source-id: 09151285af192347bd9502e97f503e06337ab1cd
@itamaro itamaro requested a review from carljm June 23, 2024 19:06
@carljm carljm added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jun 24, 2024
@carljm carljm merged commit b0e1c51 into python:main Jun 24, 2024
38 checks passed
@miss-islington-app
Copy link

Thanks @itamaro for the PR, and @carljm for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2024
@itamaro @miss-islington
pythongh-120373: Mark test_audit.test_http as requiring the network r…
d25bba9 
…esource (pythonGH-120374)

(cherry picked from commit b0e1c51)

Co-authored-by: Itamar Oren <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2024
@itamaro @miss-islington
pythongh-120373: Mark test_audit.test_http as requiring the network r…
090391a 
…esource (pythonGH-120374)

(cherry picked from commit b0e1c51)

Co-authored-by: Itamar Oren <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jun 24, 2024

GH-120948 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 24, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jun 24, 2024

GH-120949 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jun 24, 2024
carljm pushed a commit that referenced this pull request Jun 24, 2024
@miss-islington @itamaro
[3.12] gh-120373: Mark test_audit.test_http as requiring the network …
7a874b4 
…resource (GH-120374) (#120949)

gh-120373: Mark test_audit.test_http as requiring the network resource (GH-120374)
(cherry picked from commit b0e1c51)

Co-authored-by: Itamar Oren <[email protected]>
carljm pushed a commit that referenced this pull request Jun 24, 2024
@miss-islington @itamaro
[3.13] gh-120373: Mark test_audit.test_http as requiring the network …
502a99a 
…resource (GH-120374) (#120948)

gh-120373: Mark test_audit.test_http as requiring the network resource (GH-120374)
(cherry picked from commit b0e1c51)

Co-authored-by: Itamar Oren <[email protected]>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@itamaro @mrahtz
pythongh-120373: Mark test_audit.test_http as requiring the network r…
1751bb2 
…esource (python#120374)
@itamaro itamaro deleted the gh120373-test-audit-http-network branch July 6, 2024 21:31
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@itamaro @noahbkim
pythongh-120373: Mark test_audit.test_http as requiring the network r…
aac2132 
…esource (python#120374)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@itamaro @estyxx
pythongh-120373: Mark test_audit.test_http as requiring the network r…
1278cfc 
…esource (python#120374)
facebook-github-bot pushed a commit to facebookincubator/cinder that referenced this pull request Feb 10, 2025
@itamaro @facebook-github-bot
Backport gh-120373: Mark test_audit.test_http as requiring the networ…
a38e9ae 
…k resource

Summary:
upstream issue: python/cpython#120373
upstream PR: python/cpython#120374

Running the test_audit test with no resources enabled in an environment with no Internet access takes ~9 minutes. Most of that time is spent waiting for test_http to timeout on network:

Reviewed By: yilei

Differential Revision: D69376997

fbshipit-source-id: 4aa2b0851dc6fdfe28870ed0fa3d95805706c84e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carljm carljm carljm approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itamaro @carljm