Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-120544: Add else: fail() to tests where exception is expected #120545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2024
Merged

gh-120544: Add else: fail() to tests where exception is expected #120545

merged 1 commit into from
Jun 15, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jun 15, 2024 •
edited by bedevere-app bot
Loading

@sobolevn sobolevn added skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jun 15, 2024
@sobolevn sobolevn requested a review from iritkatriel as a code owner June 15, 2024 10:09
@bedevere-app bedevere-app bot mentioned this pull request Jun 15, 2024
Closed
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels Jun 15, 2024
serhiy-storchaka
serhiy-storchaka approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Normally, we could use assertRaises, but these cases are close to testing unittest itself.

@sobolevn sobolevn enabled auto-merge (squash) June 15, 2024 10:22
@sobolevn sobolevn merged commit 42ebdd8 into python:main Jun 15, 2024
38 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 15, 2024
@sobolevn @miss-islington
pythongh-120544: Add else: fail() to tests where exception is expec…
944b4eb 
…ted (pythonGH-120545)

(cherry picked from commit 42ebdd8)

Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 15, 2024
@sobolevn @miss-islington
pythongh-120544: Add else: fail() to tests where exception is expec…
fac3505 
…ted (pythonGH-120545)

(cherry picked from commit 42ebdd8)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jun 15, 2024

GH-120546 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 15, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jun 15, 2024

GH-120547 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jun 15, 2024
AlexWaygood pushed a commit that referenced this pull request Jun 15, 2024
@miss-islington @sobolevn
[3.13] gh-120544: Add else: fail() to tests where exception is expe…
767c955 
…cted (GH-120545) (#120546)

gh-120544: Add `else: fail()` to tests where exception is expected (GH-120545)
(cherry picked from commit 42ebdd8)

Co-authored-by: Nikita Sobolev <[email protected]>
AlexWaygood pushed a commit that referenced this pull request Jun 15, 2024
@miss-islington @sobolevn
[3.12] gh-120544: Add else: fail() to tests where exception is expe…
454f7e8 
…cted (GH-120545) (#120547)

gh-120544: Add `else: fail()` to tests where exception is expected (GH-120545)
(cherry picked from commit 42ebdd8)

Co-authored-by: Nikita Sobolev <[email protected]>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@sobolevn @mrahtz
pythongh-120544: Add else: fail() to tests where exception is expec…
2f17f81 
…ted (python#120545)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@sobolevn @noahbkim
pythongh-120544: Add else: fail() to tests where exception is expec…
7adf08d 
…ted (python#120545)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@sobolevn @estyxx
pythongh-120544: Add else: fail() to tests where exception is expec…
68ddc11 
…ted (python#120545)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @serhiy-storchaka @AlexWaygood