Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-121621: Use PyMutex for writes to asyncio state #121622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 14, 2024
Merged

gh-121621: Use PyMutex for writes to asyncio state #121622

merged 9 commits into from
Jul 14, 2024

Conversation

Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Jul 11, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jul 11, 2024
Closed
colesbury
colesbury reviewed Jul 11, 2024
View reviewed changes
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mutex locking should be limited to the free-threaded build. You can define some macros that that lock the mutex, but are are no-ops if Py_GIL_DISABLED is not defined.

@kumaraditya303 kumaraditya303 self-assigned this Jul 12, 2024
colesbury
colesbury reviewed Jul 12, 2024
View reviewed changes
colesbury
colesbury approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one minor comment. It'd be good to get @kumaraditya303's feedback as well.

@Fidget-Spinner Fidget-Spinner mentioned this pull request Jul 13, 2024
Merged
kumaraditya303
kumaraditya303 reviewed Jul 14, 2024
View reviewed changes
kumaraditya303
kumaraditya303 reviewed Jul 14, 2024
View reviewed changes
kumaraditya303
kumaraditya303 reviewed Jul 14, 2024
View reviewed changes
@kumaraditya303 kumaraditya303 enabled auto-merge (squash) July 14, 2024 12:00
@kumaraditya303 kumaraditya303 merged commit 5d6861a into python:main Jul 14, 2024
34 checks passed
@Fidget-Spinner Fidget-Spinner deleted the lock_asyncio branch July 14, 2024 13:03
@Fidget-Spinner
Copy link
Member Author

Thanks @kumaraditya303 for the reviews!

@colesbury colesbury added the needs backport to 3.13 bugs and security fixes label Jul 14, 2024
@miss-islington-app
Copy link

Thanks @Fidget-Spinner for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @Fidget-Spinner and @kumaraditya303, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5d6861ad06b524358f52603f242e7c0d57532a58 3.13

colesbury pushed a commit to colesbury/cpython that referenced this pull request Jul 14, 2024
@Fidget-Spinner @kumaraditya303 @colesbury
[3.13] pythongh-121621: Use PyMutex for writes to asyncio state (pyth…
e28808d 
…onGH-121622)

(cherry picked from commit 5d6861a)

Co-authored-by: Ken Jin <[email protected]>
Co-authored-by: Kumar Aditya <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jul 14, 2024

GH-121774 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 14, 2024
kumaraditya303 added a commit that referenced this pull request Jul 15, 2024
@colesbury @Fidget-Spinner @kumaraditya303
[3.13] gh-121621: Use PyMutex for writes to asyncio state (GH-121622) (…
a2a4f5e 
…#121774)

(cherry picked from commit 5d6861a)

Co-authored-by: Ken Jin <[email protected]>
Co-authored-by: Kumar Aditya <[email protected]>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@Fidget-Spinner @kumaraditya303 @estyxx
pythongh-121621: Use PyMutex for writes to asyncio state (python#121622)
9bd2dd2 
Co-authored-by: Kumar Aditya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

@kumaraditya303 kumaraditya303

Labels
skip news topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fidget-Spinner @colesbury @kumaraditya303