Thanks to visit codestin.com
Credit goes to github.com

Skip to content

GH-105879: Note exec/eval keyword change in What's New #121831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2024
Merged

GH-105879: Note exec/eval keyword change in What's New #121831

merged 1 commit into from
Jul 16, 2024

Conversation

ncoghlan
Copy link
Contributor

@ncoghlan ncoghlan commented Jul 16, 2024 •
edited by github-actions bot
Loading

@ncoghlan ncoghlan added docs Documentation in the Doc dir 3.13 bugs and security fixes needs backport to 3.13 bugs and security fixes labels Jul 16, 2024
@bedevere-app bedevere-app bot mentioned this pull request Jul 16, 2024
Closed
@ncoghlan ncoghlan enabled auto-merge (squash) July 16, 2024 03:36
webknjaz added a commit to webknjaz/cpython that referenced this pull request Jul 16, 2024
@webknjaz
🧪🚑 Fix using check_source flags as bool
1372f5b 
Previously, those flags would sometimes end up having empty string
values which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.

This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry.

This should help make PRs like python#121831 mergeable again.

[1]: python#121766 (comment)
webknjaz added a commit to webknjaz/cpython that referenced this pull request Jul 16, 2024
@webknjaz
🧪🚑 Fix using check_source flags as bool
246cdb7 
Previously, those flags would sometimes end up having empty string
values which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.

This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry [[2]].

This should help make PRs like python#121831 mergeable again.

[1]: python#121766 (comment)
[2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244
webknjaz added a commit to webknjaz/cpython that referenced this pull request Jul 16, 2024
@webknjaz
🧪🚑 Fix using check_source flags as bool
911e78f 
Previously, those flags would sometimes end up having empty string
values, which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.

This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry [[2]].

This should help make PRs like python#121831 mergeable again.

[1]: python#121766 (comment)
[2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244
@webknjaz webknjaz mentioned this pull request Jul 16, 2024
Merged
webknjaz added a commit to webknjaz/cpython that referenced this pull request Jul 16, 2024
@webknjaz
🧪🚑 Fix using check_source flags as bool
724f8e8 
Previously, those flags would sometimes end up having empty string
values, which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.

This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry [[2]].

This should help make PRs like python#121831 mergeable again.

[1]: python#121766 (comment)
[2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244
webknjaz added a commit to webknjaz/cpython that referenced this pull request Jul 16, 2024
@webknjaz
🧪🚑 Fix using check_source flags as bool
4069c5f 
Previously, those flags would sometimes end up having empty string
values, which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.

This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry [[2]].

This should help make PRs like python#121831 mergeable again.

[1]: python#121766 (comment)
[2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244
@hugovk hugovk force-pushed the exec-eval-keyword-args-whats-new branch from cb46041 to 101ca8b Compare July 16, 2024 13:00
@hugovk
Copy link
Member

hugovk commented Jul 16, 2024

Rebased to check if #121848 fixes the CI.

@webknjaz
Copy link
Contributor

🤞

@ambv
Copy link
Contributor

ambv commented Jul 16, 2024

At least the name of the skipped Windows job is still borked.

"Tests / Windows ${{ ((fromJSON(matrix.free-threading) && '(free-threading)') || '') }} (pull_requ"

@ncoghlan ncoghlan merged commit d7a099d into python:main Jul 16, 2024
24 checks passed
@miss-islington-app
Copy link

Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 16, 2024
@ncoghlan @miss-islington
pythonGH-105879: Note exec/eval keyword change in What's New (pythonG…
8cb9780 
…H-121831)

(cherry picked from commit d7a099d)

Co-authored-by: Alyssa Coghlan <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jul 16, 2024

GH-121852 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 16, 2024
@webknjaz
Copy link
Contributor

At least the name of the skipped Windows job is still borked.

That's expected. GHA doesn't evaluate skipped matrices, and that would've evaluated to two different names, not one. That's how GHA works. But in general, you don't need to look into those skipped entries as the ones that are of interest to you are prominently marked as red.

@webknjaz
Copy link
Contributor

@ambv a workaround would be to use a static name: entry and embed the variable bits into the reusable workflow job names one level below. I personally don't really care, but if that annoys you enough, we could go for it.

@webknjaz
Copy link
Contributor

Though, there might be other limitations with this (some sort of a ${{ '' }} expression, even empty, is usually needed for nicer display in the sidebar when the jobs are actually run).

@webknjaz webknjaz mentioned this pull request Jul 16, 2024
Merged
ncoghlan added a commit that referenced this pull request Jul 16, 2024
@miss-islington @ncoghlan @ambv
[3.13] GH-105879: Note exec/eval keyword change in What's New (GH-121831
c11d789 
) (#121852)

GH-105879: Note exec/eval keyword change in What's New (GH-121831)
(cherry picked from commit d7a099d)

Co-authored-by: Alyssa Coghlan <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@ncoghlan @estyxx
pythonGH-105879: Note exec/eval keyword change in What's New (pythonG…
38c99dc 
…H-121831)
@webknjaz
Copy link
Contributor

@ambv if you still want the job names to be rendered differently — let me know, and I can come up with alternative options.

@ambv
Copy link
Contributor

ambv commented Jul 24, 2024

OK, thanks! Let's see how it looks for a while and we'll decide if it's still bothering me later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3.13 bugs and security fixes docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncoghlan @hugovk @webknjaz @ambv