bpo-36211: Change the output with the full URL when executing make -C Doc/ serve
#12195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remilapeyre
reviewed
Mar 6, 2019
Tools/scripts/serve.py
Outdated
| @@ -28,7 +28,7 @@ def app(environ, respond): | |||
| path = sys.argv[1] | |||
| port = int(sys.argv[2]) if len(sys.argv) > 2 else 8000 | |||
| httpd = simple_server.make_server('', port, app) | |||
| print("Serving {} on port {}, control-C to stop".format(path, port)) | |||
| print("Serving {0} on 0.0.0.0 port {1} (http://0.0.0.0:{1}/), control-C to stop".format(path, port)) | |||
There was a problem hiding this comment.
What do you think about using an f-string here?
There was a problem hiding this comment.
I could use a f-string but you can not build the documentation with python 3.5 (not compliant with the f-string)
remilapeyre
approved these changes
Mar 6, 2019
|
While we're at it, and sorry for the ping-pongs in this issue, why the Makefile is not simply using your |
|
Maybe superseeded by #12408 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36211