-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-119180: annotationlib: Fix __all__, other minor fixes #122365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"call_evaluate_function", | ||
"get_annotate_function", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two were missing. The rest of the changes in this file are just formatting.
else: | ||
self.assertIs(annotate_func, None) | ||
|
||
|
||
class TestAnnotationLib(unittest.TestCase): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only non-formatting change in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the first stdlib module we're proposing to use autoformatting for, is it worth checking on Discourse? Autoformatters are much more opionated than PEP 8, which may be a surprising experience for contributors (note @encukou ran into an issue with a similar tool just whilst making a change to a CPython-only docs extension).
A
I hoped it wouldn't be controversial since we're already doing it for some of the |
Uh oh!
There was an error while loading. Please reload this page.