Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-116402: Avoid readline in test_builtin TTY input tests #122447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 30, 2024
Merged

gh-116402: Avoid readline in test_builtin TTY input tests #122447

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
59b63dd
gh-116402: Avoid readline in test_builtin TTY input tests
ambv Jul 30, 2024
caff72b
Better placement of `detach_readline()`
ambv Jul 30, 2024
fa61261
Use the import_helper for even fewer LOC
ambv Jul 30, 2024
0d3ac18
Use try:finally: around `yield`
ambv Jul 30, 2024
596ab9d
Merge branch 'main' into gh-116402
ambv Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use the import_helper for even fewer LOC
  • Loading branch information
@ambv
ambv committed Jul 30, 2024
commit fa61261526307530cf002e9842fa196ff6c92bd0
8 changes: 2 additions & 6 deletions Lib/test/test_builtin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
import fractions
import gc
import io
import importlib
import locale
import math
import os
Expand All @@ -32,6 +31,7 @@
from operator import neg
from test import support
from test.support import (cpython_only, swap_attr, maybe_get_event_loop_policy)
from test.support.import_helper import import_module
from test.support.os_helper import (EnvironmentVarGuard, TESTFN, unlink)
from test.support.script_helper import assert_python_ok
from test.support.warnings_helper import check_warnings
Expand Down Expand Up @@ -2413,11 +2413,7 @@ def detach_readline(self):
# since test_builtin is not intended to test
# the readline module, but the builtins module.
if "readline" in sys.modules:
try:
c = importlib.import_module("ctypes")
except ImportError:
self.skipTest("the readline module is loaded")

c = import_module("ctypes")
fp_api = "PyOS_ReadlineFunctionPointer"
prev_value = c.c_void_p.in_dll(c.pythonapi, fp_api).value
c.c_void_p.in_dll(c.pythonapi, fp_api).value = None
Expand Down