gh-122519: Adding socket module shutdown() constants description #122543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
reviewed
Aug 1, 2024
Modify some grammar Adding availability
ace016e to
567ef43
Compare
picnixz
approved these changes
Aug 1, 2024
|
By the way, no need to merge the main branch into your branch. It's better to only merge the main branch if there are conflicts and you need to solve those conflicts (otherwise, I would be notified of such action, thinking that there was an actual change). |
|
Understood! Sorry I didn`t noticed that. |
vadmium
reviewed
Aug 2, 2024
vadmium
reviewed
Aug 2, 2024
|
Should we merge this ? |
kumaraditya303
approved these changes
Aug 17, 2024
|
Thanks @Damien-Chen for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 17, 2024
pythonGH-122543) (cherry picked from commit 8a59dec) Co-authored-by: Damien <[email protected]>
|
GH-123093 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 17, 2024
pythonGH-122543) (cherry picked from commit 8a59dec) Co-authored-by: Damien <[email protected]>
|
GH-123094 is a backport of this pull request to the 3.12 branch. |
jeremyhylton
pushed a commit
to jeremyhylton/cpython
that referenced
this pull request
Aug 19, 2024
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to ##122519, adding constant argument description for
socket.shutdown()method.📚 Documentation preview 📚: https://cpython-previews--122543.org.readthedocs.build/