bpo-36253: Remove use after free reference in ctypes test suite #12257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdemeyer
requested changes
May 16, 2019
There was a problem hiding this comment.
@matrixise Does this needs a NEWS entry? I don't think so, it would just clutter the changelog. I ask you since you've been adding skip news labels to various of my PRs.
Other than that, I approve the patch. The point of that test is unclear to me.
Remove unnecessary elaboration of the old (bad, useless) test. Just mention that 'r' is now a dangling pointer and leave it at that.
Delete the news blurb, as minor changes to the ctypes test suite are not newsworthy.
|
This doesn't need a news entry, no. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes invalid reference to freed memory in ctypes test case.
Once buf is deleted and freed r becomes a dangling pointer, further use requires reading from freed memory.
Bug found using asan, full details and stack trace attached in the bug tracker.
https://bugs.python.org/issue36253