gh-116622: Rename build variable MODULE_LDFLAGS back to LIBPYTHON #122764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 6, 2024
erlend-aasland
approved these changes
Aug 7, 2024
|
@erlend-aasland: Thanks; are you able to merge this? There will also be a 3.13 backport. |
This comment was marked as outdated.
This comment was marked as outdated.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 8, 2024
…ON (pythonGH-122764) (LIBPYTHON was renamed MODULE_LDFLAGS in commit 7f5e3f0.) (cherry picked from commit 2f5c3b0) Co-authored-by: Malcolm Smith <[email protected]>
|
GH-122842 is a backport of this pull request to the 3.13 branch. |
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
…ON (python#122764) (LIBPYTHON was renamed MODULE_LDFLAGS in commit 7f5e3f0.)
|
Could it be that pkg-config is not used on Android? After this the .pc file contains this under cygwin: which is not valid syntax. I'd assume it is broken under Android too. edit: (or maybe it was the previous change this tried to fix?) |
|
yes, also broken for Android, I've filed #138800 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This variable was renamed to MODULE_LDFLAGS in #115780, but as discussed at #115780 (comment), Meson depends on the old name LIBPYTHON. Some other package build scripts probably have the same issue.