bpo-31062: Allow socket.makefile to handle line buffering properly #12370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Misc/NEWS.d/next/Library/2019-03-16-17-59-18.bpo-31062.8vxQyS.rst
Outdated
Show resolved
Hide resolved
Misc/NEWS.d/next/Library/2019-03-16-17-59-18.bpo-31062.8vxQyS.rst
Outdated
Show resolved
Hide resolved
Line buffering is enabled by using the argument `buffering=1` as defined in `io.open`.
|
This PR is stale because it has been open for 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line buffering is enabled by using the argument
buffering=1as defined inio.open.I did not update the docs for socket.makefile since it already mentions the arguments being interpreted the same way as
open:https://bugs.python.org/issue31062