Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-97588: remove unused functions in _ctypes/cfield.c #124010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2024
Merged

gh-97588: remove unused functions in _ctypes/cfield.c #124010

merged 1 commit into from
Sep 16, 2024

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Sep 12, 2024 •
edited by bedevere-app bot
Loading 

./Modules/_ctypes/cfield.c:49:12: warning: unused function 'round_down' [-Wunused-function]
Py_ssize_t round_down(Py_ssize_t numToRound, Py_ssize_t multiple)
           ^
./Modules/_ctypes/cfield.c:59:12: warning: unused function 'round_up' [-Wunused-function]
Py_ssize_t round_up(Py_ssize_t numToRound, Py_ssize_t multiple)
           ^
./Modules/_ctypes/cfield.c:409:12: warning: unused function 'BUILD_SIZE' [-Wunused-function]
Py_ssize_t BUILD_SIZE(Py_ssize_t bitsize, Py_ssize_t offset) {

@bedevere-app bedevere-app bot mentioned this pull request Sep 12, 2024
Closed
@picnixz picnixz mentioned this pull request Sep 16, 2024
Closed
@encukou encukou merged commit 453da53 into python:main Sep 16, 2024
37 checks passed
@encukou
Copy link
Member

encukou commented Sep 16, 2024

Thanks for the catch!

vstinner
vstinner reviewed Sep 16, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge review: LGTM :-)

savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this pull request Sep 22, 2024
@iritkatriel @savannahostrowski
pythongh-97588: remove unused functions in _ctypes/cfield.c (pythonGH…
5e54211 
…-124010)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

@encukou encukou Awaiting requested review from encukou

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iritkatriel @encukou @vstinner