Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[3.13] gh-124043: Disallow mixing --with-trace-refs and --disable-gil (GH-124078) #124138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yhg1s merged 1 commit into from
Sep 24, 2024
Merged

[3.13] gh-124043: Disallow mixing --with-trace-refs and --disable-gil (GH-124078) #124138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-124043: Disallow mixing --with-trace-refs and --disable-gil (G… 
…H-124078)

Tracing references is not currently thread-safe in the free-threaded build.
(cherry picked from commit 3b45df0)

Co-authored-by: Peter Bierma <[email protected]>
  • Loading branch information
@ZeroIntensity @miss-islington
ZeroIntensity authored and miss-islington committed Sep 16, 2024
commit fd6cfdfd2faddd3b46273220b4ae3274cae7953d
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Build/2024-09-13-17-48-37.gh-issue-124043.Bruxpq.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Building using :option:`--with-trace-refs` is (temporarily) disallowed when the
GIL is disabled.
4 changes: 4 additions & 0 deletions configure
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1777,6 +1777,10 @@ then
[Define if you want to enable tracing references for debugging purpose])
fi

if test "$disable_gil" = "yes" -a "$with_trace_refs" = "yes";
then
AC_MSG_ERROR([--disable-gil cannot be used with --with-trace-refs])
fi

# Check for --enable-pystats
AC_MSG_CHECKING([for --enable-pystats])
Expand Down