GH-108009: Add clarification of parser and argument defaults in argparse docs #124154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAM-Gerlach
reviewed
Sep 20, 2024
There was a problem hiding this comment.
(Stock reminder: You can apply my suggestions with one click using the Commit suggestion button :)
I agree with the change overall, though I left a suggestion to make it substantially shorter, simpler and clearer, which hopefully helps address others' concerns about overcomplicating the docs. Thanks!
Co-authored-by: C.A.M. Gerlach <[email protected]>
|
@hpaulj, does this change satisfy your criteria? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clarifies the nuances of setting defaults at the parser and argument level using argparse.
📚 Documentation preview 📚: https://cpython-previews--124154.org.readthedocs.build/