Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-124606: Fix reference leak in error path in datetime_fromisoformat in _datetimemodule.c #124607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2024
Merged

gh-124606: Fix reference leak in error path in datetime_fromisoformat in _datetimemodule.c #124607

merged 1 commit into from
Sep 26, 2024

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented Sep 26, 2024 •
edited by bedevere-app bot
Loading

@Eclips4 Eclips4 requested review from vstinner and picnixz September 26, 2024 15:06
@Eclips4 Eclips4 changed the title Fix reference leak in _datetimemodule.c gh-124606: Fix reference leak in _datetimemodule.c Sep 26, 2024
@bedevere-app bedevere-app bot mentioned this pull request Sep 26, 2024
Closed
picnixz
picnixz approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! (though I find the gotos a bit too hard to follow in this specific function). Do you want to run the refleak build bots?

vstinner
vstinner approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I confirm that ./python -m test test_datetime -R 3:3 no longer leaks with this change.

For the PR title, you may refer to datetime_fromisoformat() which is more precise ;-)

@vstinner
Copy link
Member

Do you want to run the refleak build bots?

It's not needed. I tested manually.

@Eclips4 Eclips4 changed the title gh-124606: Fix reference leak in _datetimemodule.c gh-124606: Fix reference leak in error path in datetime_fromisoformat in _datetimemodule.c Sep 26, 2024
@Eclips4 Eclips4 enabled auto-merge (squash) September 26, 2024 15:18
@Eclips4 Eclips4 disabled auto-merge September 26, 2024 15:23
@Eclips4 Eclips4 enabled auto-merge (squash) September 26, 2024 15:26
@Eclips4 Eclips4 merged commit 9c98fda into python:main Sep 26, 2024
39 checks passed
@Eclips4 Eclips4 deleted the issue-124606 branch September 26, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@picnixz picnixz picnixz approved these changes

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eclips4 @vstinner @picnixz