Thanks to visit codestin.com
Credit goes to github.com

Skip to content

WIP: bpo-36345: Remove the deprecated Tools/scripts/serve.py script #12522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

matrixise
Copy link
Member

@matrixise matrixise commented Mar 24, 2019

This PR should be merged after the PR #12408. Once that one will merged I will remove the WIP status for a review.

https://bugs.python.org/issue36345

@matrixise matrixise changed the title bpo-36345: Remove the deprecated Tools/scripts/serve.py script WIP: bpo-36345: Remove the deprecated Tools/scripts/serve.py script Mar 24, 2019
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned on the bug tracker issue, I don't think we should delete this since it and other files in the Tools directory are or optionally are installed on users' systems as part of some distribution packages and it still serves its purpose as a demo.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@matrixise
Copy link
Member Author

I close this PR, we will avoid to merge it. Thanks @ned-deily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants