Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-36427: Document that PyEval_RestoreThread and PyGILState_Ensure can terminate the calling thread #12541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2019

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Mar 25, 2019

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I have a question :-)

@pablogsal pablogsal merged commit fde9b33 into python:master Apr 13, 2019
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@pablogsal pablogsal deleted the gil_warning branch April 13, 2019 16:23
pablogsal added a commit to pablogsal/cpython that referenced this pull request Apr 13, 2019
…sure can terminate the calling thread (pythonGH-12541)

Calling these function from a thread when the runtime is finalizing will terminate
the thread, even if the thread was not created by Python. Users can use
_Py_IsFinalizing or sys.is_finalizing to check if the interpreter is in the process of
being finalized before calling this function to avoid unwanted termination.
(cherry picked from commit fde9b33)

Co-authored-by: Pablo Galindo <[email protected]>
@bedevere-bot
Copy link

GH-12820 is a backport of this pull request to the 3.7 branch.

pablogsal added a commit that referenced this pull request Apr 14, 2019
…sure can terminate the calling thread (GH-12541) (GH-12820)

Calling these function from a thread when the runtime is finalizing will terminate
the thread, even if the thread was not created by Python. Users can use
_Py_IsFinalizing or sys.is_finalizing to check if the interpreter is in the process of
being finalized before calling this function to avoid unwanted termination.
(cherry picked from commit fde9b33)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants