gh-125331: Allow the parser to activate future imports on the fly #125482

pablogsal · 2024-10-14T20:24:38Z

Issue: from __future__ import barry_as_FLUFL doesn't work #125331

nineteendo · 2024-10-14T20:43:31Z

Eh, not sure if this is desirable, maybe lock the future behind a repl compiler flag:

# tmp.py
from __future__ import barry_as_FLUFL
1 != 2

$ gh-125331/python.exe tmp.py
  File "/Users/wannes/Documents/GitHub/cpython/tmp.py", line 2
    1 != 2
      ^^
SyntaxError: with Barry as BDFL, use '<>' instead of '!='

This is great though:

>>> from __future__ import barry_as_FLUFL
... 1 <> 2
... 
True

nineteendo · 2024-10-14T21:05:25Z

This change isn't backwards compatible, although it only affects 14 files (Github search).

JelleZijlstra · 2024-10-14T21:40:21Z

Eh, not sure if this is desirable, maybe lock the future behind a repl compiler flag

I feel it should work like any other future import, so it can serve as an example.

This change isn't backwards compatible, although it only affects 14 files (Github search).

I feel those people are asking for it; they're using an undocumented joke feature. We can limit this change to 3.14 though.

pablogsal · 2024-10-14T21:45:01Z

Eh, not sure if this is desirable, maybe lock the future behind a repl compiler flag:

The whole point of this is that it works everywhere, not just in the REPL

This change isn't backwards compatible, although it only affects 14 files (Github search).

haha, we need to decide if is a bug or if is not. If we decide this should work everywhere the fact that those people are using is fixing the bug. In the issue I said I don't think this is a bug, but if we decide that it is, then it is not backwards incompatible: it's fixing a bug. Notice there is no documentation about how this is supposed to work and all observable behaviour is not protected for backwards compatibility.

nineteendo · 2024-10-15T05:39:50Z

cc @warsaw

thatbirdguythatuknownot · 2024-10-15T12:07:56Z

How about the multiple-name imports?

from __future__ import annotations, barry_as_FLUFL
x: A
print(__annotations__['x'])  # A
print(1 <> 2)  # True

If I'm looking at the code correctly, it only accepts single-name imports for now..

lysnikolaou

I'm generally okay with this, I think we do some similar hacky things elsewhere.

A couple of minor comments.

Grammar/python.gram

Parser/action_helpers.c

pablogsal · 2024-10-15T14:26:10Z

How about the multiple-name imports?
from __future__ import annotations, barry_as_FLUFL
x: A
print(__annotations__['x'])  # A
print(1 <> 2)  # True
If I'm looking at the code correctly, it only accepts single-name imports for now..

Yeah, the PR is only a draft for evaluating the idea, is still missing many things like tests, NEWs...etc

Grammar/python.gram

pablogsal · 2024-10-29T23:34:13Z

@lysnikolaou can you take another look?

Lib/test/test_grammar.py

lysnikolaou

LGTM! 🎉 A couple of very nitty comments. Feel free to diregard.

Parser/action_helpers.c

Misc/NEWS.d/next/Core_and_Builtins/2024-10-29-23-30-35.gh-issue-125331.quKQ7V.rst

Parser/action_helpers.c

Lib/test/test_flufl.py

Misc/NEWS.d/next/Core_and_Builtins/2024-10-29-23-30-35.gh-issue-125331.quKQ7V.rst

Parser/action_helpers.c

picnixz

Thanks Pablo & Jelle for answering my questions!

Misc/NEWS.d/next/Core_and_Builtins/2024-10-29-23-30-35.gh-issue-125331.quKQ7V.rst

JelleZijlstra

Someone alluded to it above, but this incorrectly picks up relative future imports:

>>> from .__future__ import barry_as_FLUFL; 1 <> 2
Traceback (most recent call last):
  File "<python-input-4>", line 1, in <module>
    from .__future__ import barry_as_FLUFL; 1 <> 2
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ModuleNotFoundError: No module named '_pyrepl.__future__'
True
>>> from .__future__ import barry_as_FLUFLx; 1 <> 2
  File "<python-input-5>", line 1
    from .__future__ import barry_as_FLUFLx; 1 <> 2
                                               ^^
SyntaxError: invalid syntax

The first one correctly throws ModuleNotFoundError, but it also allows 1 <> 2. The second one throws a SyntaxError as expected.

Co-authored-by: Lysandros Nikolaou <[email protected]> Co-authored-by: Nice Zombies <[email protected]> Signed-off-by: Pablo Galindo <[email protected]>

Co-authored-by: Lysandros Nikolaou <[email protected]> Co-authored-by: Bénédikt Tran <[email protected]>

…e-125331.quKQ7V.rst Co-authored-by: Bénédikt Tran <[email protected]>

Co-authored-by: Nice Zombies <[email protected]>

…e-125331.quKQ7V.rst Co-authored-by: Jelle Zijlstra <[email protected]>

…gh-issue-125331.quKQ7V.rst

pablogsal · 2025-02-13T00:51:01Z

@JelleZijlstra I have fixed the relative imports, rebased and added a test, can you review it again?

miss-islington-app · 2025-03-10T21:56:55Z

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app · 2025-03-10T21:56:57Z

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

…ly (pythonGH-125482) (cherry picked from commit 3bd3e09) Co-authored-by: Pablo Galindo Salgado <[email protected]>

bedevere-app · 2025-03-10T21:57:04Z

GH-131062 is a backport of this pull request to the 3.13 branch.

…ly (pythonGH-125482) (cherry picked from commit 3bd3e09) Co-authored-by: Pablo Galindo Salgado <[email protected]>

bedevere-app · 2025-03-10T21:57:09Z

GH-131063 is a backport of this pull request to the 3.12 branch.

…fly (GH-125482) (#131063) gh-125331: Allow the parser to activate future imports on the fly (GH-125482) (cherry picked from commit 3bd3e09) Co-authored-by: Pablo Galindo Salgado <[email protected]>

…fly (GH-125482) (#131062) gh-125331: Allow the parser to activate future imports on the fly (GH-125482) (cherry picked from commit 3bd3e09) Co-authored-by: Pablo Galindo Salgado <[email protected]>

bedevere-app bot mentioned this pull request Oct 14, 2024

from __future__ import barry_as_FLUFL doesn't work #125331

Closed

lysnikolaou reviewed Oct 15, 2024

View reviewed changes

Grammar/python.gram Outdated Show resolved Hide resolved

Parser/action_helpers.c Outdated Show resolved Hide resolved

nineteendo reviewed Oct 15, 2024

View reviewed changes

Parser/action_helpers.c Outdated Show resolved Hide resolved

pablogsal commented Oct 15, 2024

View reviewed changes

Grammar/python.gram Outdated Show resolved Hide resolved

pablogsal force-pushed the gh-125331 branch 3 times, most recently from cd167c2 to 8fb86b3 Compare October 29, 2024 23:33

pablogsal marked this pull request as ready for review October 29, 2024 23:47

bedevere-app bot added the awaiting core review label Oct 29, 2024

nineteendo reviewed Oct 30, 2024

View reviewed changes

Lib/test/test_grammar.py Outdated Show resolved Hide resolved

lysnikolaou approved these changes Oct 30, 2024

View reviewed changes

Parser/action_helpers.c Outdated Show resolved Hide resolved

Misc/NEWS.d/next/Core_and_Builtins/2024-10-29-23-30-35.gh-issue-125331.quKQ7V.rst Outdated Show resolved Hide resolved

bedevere-app bot added awaiting merge and removed awaiting core review labels Oct 30, 2024

picnixz reviewed Oct 30, 2024

View reviewed changes

Parser/action_helpers.c Outdated Show resolved Hide resolved

picnixz reviewed Oct 30, 2024

View reviewed changes

Lib/test/test_flufl.py Show resolved Hide resolved

pablogsal commented Oct 30, 2024

View reviewed changes

Lib/test/test_flufl.py Show resolved Hide resolved

pablogsal commented Oct 30, 2024

View reviewed changes

Lib/test/test_flufl.py Show resolved Hide resolved

picnixz reviewed Oct 30, 2024

View reviewed changes

Misc/NEWS.d/next/Core_and_Builtins/2024-10-29-23-30-35.gh-issue-125331.quKQ7V.rst Outdated Show resolved Hide resolved

Parser/action_helpers.c Show resolved Hide resolved

Parser/action_helpers.c Outdated Show resolved Hide resolved

Parser/action_helpers.c Show resolved Hide resolved

picnixz approved these changes Oct 30, 2024

View reviewed changes

JelleZijlstra reviewed Oct 30, 2024

View reviewed changes

Misc/NEWS.d/next/Core_and_Builtins/2024-10-29-23-30-35.gh-issue-125331.quKQ7V.rst Outdated Show resolved Hide resolved

JelleZijlstra requested changes Oct 30, 2024

View reviewed changes

bedevere-app bot removed the awaiting merge label Oct 30, 2024

pablogsal and others added 9 commits February 13, 2025 00:45

Apply suggestions from code review

4ef188c

Co-authored-by: Lysandros Nikolaou <[email protected]> Co-authored-by: Nice Zombies <[email protected]> Signed-off-by: Pablo Galindo <[email protected]>

Fix whitespace

c316541

Apply suggestions from code review

d12081a

Co-authored-by: Lysandros Nikolaou <[email protected]> Co-authored-by: Bénédikt Tran <[email protected]>

Update Lib/test/test_flufl.py

68b29e4

Update Lib/test/test_flufl.py

53a237e

Update Misc/NEWS.d/next/Core_and_Builtins/2024-10-29-23-30-35.gh-issu…

941d2ed

…e-125331.quKQ7V.rst Co-authored-by: Bénédikt Tran <[email protected]>

Update action_helpers.c

f377291

Co-authored-by: Nice Zombies <[email protected]>

Update Misc/NEWS.d/next/Core_and_Builtins/2024-10-29-23-30-35.gh-issu…

babe18b

…e-125331.quKQ7V.rst Co-authored-by: Jelle Zijlstra <[email protected]>

fixup! Update Misc/NEWS.d/next/Core_and_Builtins/2024-10-29-23-30-35.…

76d8c9f

…gh-issue-125331.quKQ7V.rst

pablogsal force-pushed the gh-125331 branch from 387e67f to 76d8c9f Compare February 13, 2025 00:50

pablogsal enabled auto-merge (squash) February 13, 2025 00:51

JelleZijlstra approved these changes Feb 14, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting changes labels Feb 14, 2025

pablogsal merged commit 3bd3e09 into python:main Feb 14, 2025
45 of 46 checks passed

pablogsal deleted the gh-125331 branch February 14, 2025 04:54

bedevere-app bot removed the awaiting merge label Feb 14, 2025

pablogsal added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Mar 10, 2025

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 10, 2025

bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 10, 2025

Uh oh!

gh-125331: Allow the parser to activate future imports on the fly #125482

gh-125331: Allow the parser to activate future imports on the fly #125482

Uh oh!

Conversation

pablogsal commented Oct 14, 2024 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nineteendo commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nineteendo commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JelleZijlstra commented Oct 14, 2024

Uh oh!

pablogsal commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nineteendo commented Oct 15, 2024

Uh oh!

thatbirdguythatuknownot commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lysnikolaou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pablogsal commented Oct 15, 2024

Uh oh!

Uh oh!

pablogsal commented Oct 29, 2024

Uh oh!

Uh oh!

lysnikolaou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

picnixz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JelleZijlstra left a comment

Choose a reason for hiding this comment

Uh oh!

pablogsal commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

miss-islington-app bot commented Mar 10, 2025

Uh oh!

miss-islington-app bot commented Mar 10, 2025

Uh oh!

bedevere-app bot commented Mar 10, 2025

Uh oh!

bedevere-app bot commented Mar 10, 2025

Uh oh!

Uh oh!

pablogsal commented Oct 14, 2024 •

edited by bedevere-app bot

Loading

nineteendo commented Oct 14, 2024 •

edited

Loading

nineteendo commented Oct 14, 2024 •

edited

Loading

pablogsal commented Oct 14, 2024 •

edited

Loading

thatbirdguythatuknownot commented Oct 15, 2024 •

edited

Loading

pablogsal commented Feb 13, 2025 •

edited

Loading