review suggestions

python · kumaraditya303 · Mar 13, 2025 · Oct 19, 2024 · Oct 19, 2024 · Oct 19, 2024
commit a90d5e8ced6c98baed6154b4dd253aa99a9fc24e
diff --git a/Lib/test/test_free_threading/test_enumerate.py b/Lib/test/test_free_threading/test_enumerate.py
@@ -1,6 +1,6 @@
 import unittest
 import sys
-from threading import Thread
+from threading import Thread, Barrier
 
 from test.support import threading_helper
 
@@ -14,14 +14,14 @@ def test_threading(self):
         number_of_iterations = 8
         n = 100
         start = sys.maxsize - 40
-        workers_enabled = False
+        barrier = Barrier(number_of_threads)
         def work(enum):
+            barrier.wait()
             while True:
-                if workers_enabled:
-                    try:
-                        _ = next(enum)
-                    except StopIteration:
-                        break
+                try:
+                    _ = next(enum)
+                except StopIteration:
+                    break
 
         for _ in range(number_of_iterations):
             enum = enumerate(range(start, start + n))
@@ -31,10 +31,10 @@ def work(enum):
                     Thread(target=work, args=[enum]))
             for t in worker_threads:
                 t.start()
-            workers_enabled  = True # make sure to start all threads simultaneously
             for t in worker_threads:
                 t.join()
 
+            barrier.reset()
 
 if __name__ == "__main__":
     unittest.main()