-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
[3.13] gh-125741: Update check_generated_files CI to use our published container image (gh-125744) #125759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
erlend-aasland
merged 1 commit into
python:3.13
from
erlend-aasland:backport-3.13-ci-autoconf
Oct 21, 2024
Merged
[3.13] gh-125741: Update check_generated_files CI to use our published container image (gh-125744) #125759
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -83,6 +83,50 @@ jobs: | |
name: abi-data | ||
path: ./Doc/data/*.abi | ||
|
||
check_autoconf_regen: | ||
name: 'Check if Autoconf files are up to date' | ||
# Don't use ubuntu-latest but a specific version to make the job | ||
# reproducible: to get the same tools versions (autoconf, aclocal, ...) | ||
runs-on: ubuntu-24.04 | ||
container: | ||
image: ghcr.io/python/autoconf:2024.10.11.11293396815 | ||
timeout-minutes: 60 | ||
needs: check_source | ||
if: needs.check_source.outputs.run_tests == 'true' | ||
steps: | ||
- name: Install Git | ||
run: | | ||
apt install git -yq | ||
git config --global --add safe.directory "$GITHUB_WORKSPACE" | ||
- uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 1 | ||
- name: Runner image version | ||
run: echo "IMAGE_VERSION=${ImageVersion}" >> $GITHUB_ENV | ||
- name: Check Autoconf and aclocal versions | ||
run: | | ||
grep "Generated by GNU Autoconf 2.71" configure | ||
grep "aclocal 1.16.5" aclocal.m4 | ||
grep -q "runstatedir" configure | ||
grep -q "PKG_PROG_PKG_CONFIG" aclocal.m4 | ||
- name: Regenerate autoconf files | ||
# Same command used by Tools/build/regen-configure.sh ($AUTORECONF) | ||
run: autoreconf -ivf -Werror | ||
- name: Check for changes | ||
run: | | ||
git add -u | ||
changes=$(git status --porcelain) | ||
# Check for changes in regenerated files | ||
if test -n "$changes"; then | ||
echo "Generated files not up to date." | ||
echo "Perhaps you forgot to run make regen-all or build.bat --regen. ;)" | ||
echo "configure files must be regenerated with a specific version of autoconf." | ||
echo "$changes" | ||
echo "" | ||
git diff --staged || true | ||
exit 1 | ||
fi | ||
|
||
check_generated_files: | ||
name: 'Check if generated files are up to date' | ||
# Don't use ubuntu-latest but a specific version to make the job | ||
|
@@ -112,19 +156,10 @@ jobs: | |
uses: hendrikmuhs/[email protected] | ||
with: | ||
save: false | ||
- name: Check Autoconf and aclocal versions | ||
run: | | ||
grep "Generated by GNU Autoconf 2.71" configure | ||
grep "aclocal 1.16.5" aclocal.m4 | ||
grep -q "runstatedir" configure | ||
grep -q "PKG_PROG_PKG_CONFIG" aclocal.m4 | ||
- name: Configure CPython | ||
run: | | ||
# Build Python with the libpython dynamic library | ||
./configure --config-cache --with-pydebug --enable-shared | ||
- name: Regenerate autoconf files | ||
# Same command used by Tools/build/regen-configure.sh ($AUTORECONF) | ||
run: autoreconf -ivf -Werror | ||
- name: Build CPython | ||
run: | | ||
make -j4 regen-all | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.