gh-125887: Update PyObject_HasAttr exception behavior #125907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirpichev
reviewed
Oct 24, 2024
skirpichev
approved these changes
Oct 24, 2024
|
@Damien-Chen, please avoid force-pushes. |
|
I want to rebase and squash my commit, but |
|
Please avoid also rebase, etc. Just add new commits - all going to be squashed in a single commit on merge anyway. FYI: https://devguide.python.org/getting-started/pull-request-lifecycle/#lifecycle-of-a-pull-request |
|
Thanks @Damien-Chen for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 27, 2024
…-125907) Update PyObject_HasAttr exception behavior (cherry picked from commit 08a0728) Co-authored-by: Damien <[email protected]> Co-authored-by: Shantanu <[email protected]>
|
GH-128283 is a backport of this pull request to the 3.13 branch. |
hauntsaninja
added a commit
that referenced
this pull request
Dec 27, 2024
…) (#128283) gh-125887: Update PyObject_HasAttr exception behavior (GH-125907) Update PyObject_HasAttr exception behavior (cherry picked from commit 08a0728) Co-authored-by: Damien <[email protected]> Co-authored-by: Shantanu <[email protected]>
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
…25907) Update PyObject_HasAttr exception behavior Co-authored-by: Shantanu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #125887
📚 Documentation preview 📚: https://cpython-previews--125907.org.readthedocs.build/