take advises

python · markshannon · Oct 30, 2024 · Oct 17, 2024 · Oct 20, 2024 · Oct 22, 2024
commit 6ebadd6e604337d463d6b5d383300809ce03303a
@@ -1538,7 +1538,7 @@ Other bits in :attr:`~codeobject.co_flags` are reserved for internal use.
 
 If a code object represents a function and has a docstring,
 the first item in :attr:`~codeobject.co_consts` is
-the documentation string of the function.
+the docstring of the function.
 
 Methods on code objects
 ~~~~~~~~~~~~~~~~~~~~~~~

diff --git a/Include/cpython/code.h b/Include/cpython/code.h
@@ -174,7 +174,9 @@ struct PyCodeObject _PyCode_DEF(1);
 
 #define CO_NO_MONITORING_EVENTS 0x2000000
 
-/* Whether the first element in co_consts is doc string  */
+/* Whether the code object has a docstring,
+   If so, it will be the first item in co_consts
+*/
 #define CO_HAS_DOCSTRING 0x4000000
 
 /* This should be defined if a future statement modifies the syntax.

@@ -1244,7 +1244,7 @@ codegen_function_body(compiler *c, stmt_ty s, int is_async, Py_ssize_t funcflags
             return ERROR;
         }
         Py_ssize_t idx = _PyCompile_AddConst(c, docstring);
-        Py_XDECREF(docstring);
+        Py_DECREF(docstring);
         RETURN_IF_ERROR_IN_SCOPE(c, idx < 0 ? ERROR : SUCCESS);
     }