gh-126204: Add a sys._jit_enabled helper
#126247
Conversation
| # Temporarily enable ignore_stderr=True to ignore warnings on JIT builds | ||
| # See gh-126255 for more information | ||
| self.check_all_configs("test_initconfig_api", config, preconfig, | ||
| api=API_ISOLATED, ignore_stderr=True) |
There was a problem hiding this comment.
That's fun. Due to incorrect assumptions, where JIT is actually enabled or not, this hack is no longer needed. Just setting PYTHON_JIT=0 is enough here.
Py_JIT_ENABLED variable to pyconfig.hsys._jit_enabled helper
Misc/NEWS.d/next/Core_and_Builtins/2024-11-10-04-59-43.gh-issue-126204.ASKDL1.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
There was a problem hiding this comment.
A final nitpick. And a question: is there a lot of
_PyOptimizerObject* optimizer = _Py_GetOptimizer();
if (optimizer != NULL) {
Py_DECREF(optimizer);
...
}in the code? if so, we could perhaps have some function that checks if there is an optimizer.
EDIT: Since we are moving to removing the _PyOptimizer API, it's possible we don't need this.
Co-authored-by: Bénédikt Tran <[email protected]>
In fact, there are only two uses of |
|
Superseded by #129194 |
Py_JIT_ENABLEDvariable topyconfig.h#126204📚 Documentation preview 📚: https://cpython-previews--126247.org.readthedocs.build/