Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[3.10] gh-113027: Fix test_variable_tzname in test_email (GH-113821) #126438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

encukou
Copy link
Member

@encukou encukou commented Nov 5, 2024

Determine the support of the Kyiv timezone by checking the result of astimezone() which uses the system tz database and not the one populated by zoneinfo.
(cherry picked from commit 931d7e0)

It's the smallest change that should fix the failing buildbot; main has better code here.

…nGH-113821)

Determine the support of the Kyiv timezone by checking the result of
astimezone() which uses the system tz database and not the one
populated by zoneinfo.
(cherry picked from commit 931d7e0)

Co-authored-by: Serhiy Storchaka <[email protected]>
@encukou
Copy link
Member Author

encukou commented Nov 5, 2024

!buildbot AMD64 Ubuntu Shared

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit 3e2cee4 🤖

The command will test the builders whose names match following regular expression: AMD64 Ubuntu Shared

The builders matched are:

  • AMD64 Ubuntu Shared PR

Copy link

@ruidazeng ruidazeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change necessary?

@pablogsal pablogsal merged commit 5f24da9 into python:3.10 Nov 5, 2024
14 checks passed
@encukou
Copy link
Member Author

encukou commented Nov 6, 2024

Why is this change necessary?

Thanks for asking!
It's to fix a Buildbot worker which was just updated from Ubuntu 5.15 to 6.8.

The devguide says:

You should also consider fixing hard-failing tests in open security branches since it is important to be able to run the tests successfully before releasing.

@encukou encukou deleted the backport-931d7e0-3.10 branch November 6, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants