Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-76785: Improved Subinterpreters Compatibility with 3.12 (2/2) #126707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 6 commits into from
Nov 12, 2024
Merged

gh-76785: Improved Subinterpreters Compatibility with 3.12 (2/2) #126707

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
45ace42
Move _PyXI_GET_STATE() to the API.
ericsnowcurrently Nov 5, 2024
89230fb
Check the result of _PyXI_GET_STATE().
ericsnowcurrently Nov 7, 2024
ecb2d45
Add _PyXIData_lookup_context_t.
ericsnowcurrently Nov 5, 2024
ad7cd0d
Add state init/fini funcs.
ericsnowcurrently Nov 5, 2024
cf48016
Use the init funcs in _PyXI_Init().
ericsnowcurrently Nov 7, 2024
9b13684
lint
ericsnowcurrently Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Check the result of _PyXI_GET_STATE().
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Nov 11, 2024
commit 89230fbdea6835dd3bf190b8a54cb78f8d67b3c0
24 changes: 22 additions & 2 deletions Python/crossinterp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1779,10 +1779,21 @@ PyStatus
_PyXI_Init(PyInterpreterState *interp)
{
_PyXI_state_t *state = _PyXI_GET_STATE(interp);
if (state == NULL) {
PyErr_PrintEx(0);
return _PyStatus_ERR(
"failed to get interpreter's cross-interpreter state");
}

// Initialize the XID lookup state (e.g. registry).
if (_Py_IsMainInterpreter(interp)) {
xid_lookup_init(&_PyXI_GET_GLOBAL_STATE(interp)->data_lookup);
_PyXI_global_state_t *global_state = _PyXI_GET_GLOBAL_STATE(interp);
if (global_state == NULL) {
PyErr_PrintEx(0);
return _PyStatus_ERR(
"failed to get global cross-interpreter state");
}
xid_lookup_init(&global_state->data_lookup);
}
xid_lookup_init(&state->data_lookup);

Expand All @@ -1803,6 +1814,13 @@ void
_PyXI_Fini(PyInterpreterState *interp)
{
_PyXI_state_t *state = _PyXI_GET_STATE(interp);
assert(state != NULL);
#ifndef NDEBUG
if (state == NULL) {
PyErr_PrintEx(0);
return;
}
#endif

// Finalize exceptions (heap types).
// See _PyXI_FiniTypes() for the static types.
Expand All @@ -1811,7 +1829,9 @@ _PyXI_Fini(PyInterpreterState *interp)
// Finalize the XID lookup state (e.g. registry).
xid_lookup_fini(&state->data_lookup);
if (_Py_IsMainInterpreter(interp)) {
xid_lookup_fini(&_PyXI_GET_GLOBAL_STATE(interp)->data_lookup);
_PyXI_global_state_t *global_state = _PyXI_GET_GLOBAL_STATE(interp);
assert(global_state != NULL);
xid_lookup_fini(&global_state->data_lookup);
}
}

Expand Down