Just added a NEWS entry - I hope I did it right

@serhiy-storchaka: Would you mind to double check this change?

I am not sure that this is an issue. Non-decimal integers was accepted always. It was not documented, but user code may depend on it. We may even make it an official feature in future.

I am not sure that this is an issue.

There is still an inconsistency wrt pickle and pickletools.

It was not documented, but user code may depend on it.

What do you think on changing pickletools instead, as it was suggested in the issue thread?

If consider pickletools as a debugging tool, making it more lenient is safer.

Yeah the problem right now is that pickletools is LESS lenient because it ONLY accepts base 10, so if we want to keep the any-base feature in pickle, we should change pickletools to accept more bases than 10.

@serhiy-storchaka Would you like me to change my pull request to update pickletools.py to accept any base?

Take your time. In the end, the solution proposed in this PR may be the right solution.

How do you want to write tests? Does it require to serialize to pickle manually (reimplement pickle in tests)? I don't think that tests are needed.

There are already many similar tests. They try to unpickle the manually prepared data.

I added tests. They fail without changes in this PR.

@Legoclones, it seems you are new with Git and made a common error (don't be ashamed, it happened with me too) -- you added changes to your main branch and created a PR from it. It makes impossible to you to create new PRs -- they will include changes from this PR. The right way -- create a separate branch for every PR (see the devguide for details).

Now your fork is broken. To fix it, delete the main branch in your fork on GitHub and your local copy and checkout the main branch from the upstream. Read the devguide about configuring an upstream remote repository. Do this only after this PR have been merged.

@serhiy-storchaka:

I added tests. They fail without changes in this PR.

Oh nice, I like your tests :-) I expected something way more complicated.

@serhiy-storchaka I've had a busy week at school, so I haven't had time to write the tests yet. Thanks for doing that and getting it done. Also yeah, I realized I had committed my changes to main and not a separate branch, I'll have to recreate it.

The tests look good, thanks for working with me on it!