Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-124873: Skip timerfd tests on Android #127279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 26, 2024
Merged

gh-124873: Skip timerfd tests on Android #127279

merged 3 commits into from
Nov 26, 2024

Conversation

mhsmith
Copy link
Member

@mhsmith mhsmith commented Nov 26, 2024 •
edited
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 26, 2024
Closed
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels Nov 26, 2024
@mhsmith mhsmith requested a review from vstinner November 26, 2024 00:19
@mhsmith mhsmith added the needs backport to 3.13 bugs and security fixes label Nov 26, 2024
vstinner
vstinner reviewed Nov 26, 2024
View reviewed changes
vstinner
vstinner approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner enabled auto-merge (squash) November 26, 2024 09:30
@vstinner vstinner merged commit 4ca2c82 into python:main Nov 26, 2024
39 checks passed
@miss-islington-app
Copy link

Thanks @mhsmith for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 26, 2024
@mhsmith @vstinner @miss-islington
pythongh-124873: Skip timerfd tests on Android (pythonGH-127279)
0ef10e2 
* Revert "[3.13] pythongh-124873: Tolerate 100 ms in TimerfdTests on Android (pythonGH-127101) (pythonGH-127105)"

This reverts commit c09366b.

* Skip timerfd tests on Android.

(cherry picked from commit 4ca2c82)

Co-authored-by: Malcolm Smith <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 26, 2024

GH-127290 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 26, 2024
vstinner added a commit that referenced this pull request Nov 29, 2024
@miss-islington @mhsmith @vstinner
[3.13] gh-124873: Skip timerfd tests on Android (GH-127279) (#127290)
6a06634 
gh-124873: Skip timerfd tests on Android (GH-127279)

* Revert "[3.13] gh-124873: Tolerate 100 ms in TimerfdTests on Android (GH-127101) (GH-127105)"

This reverts commit c09366b.

* Skip timerfd tests on Android.

(cherry picked from commit 4ca2c82)

Co-authored-by: Malcolm Smith <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD14 3.13 has failed when building commit 6a06634.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1481/builds/765) and take a look at the build logs.
  4. Check if the failure is related to this commit (6a06634) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1481/builds/765

Failed tests:

  • test_threading

Failed subtests:

  • test_start_new_thread_failed - test.test_threading.ThreadTests.test_start_new_thread_failed

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.opsec-fbsd14/build/Lib/test/test_threading.py", line 1205, in test_start_new_thread_failed
    self.assertEqual(out, b'ok')
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
AssertionError: b"skipshouldn't be printed" != b'ok'

@vstinner
Copy link
Member

test_start_new_thread_failed - test.test_threading.ThreadTests.test_start_new_thread_failed

Unrelated failure. It should be fixed by #127299.

ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@mhsmith @vstinner @ebonnal
pythongh-124873: Skip timerfd tests on Android (python#127279)
bd80d60 
* Revert "[3.13] pythongh-124873: Tolerate 100 ms in TimerfdTests on Android (pythonGH-127101) (python#127105)"

This reverts commit c09366b.

* Skip timerfd tests on Android.

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhsmith @bedevere-bot @vstinner