Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-127314: Don't mention the GIL when calling without a thread state on the free-threaded build #127315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 13 commits into from
Dec 6, 2024
Merged

gh-127314: Don't mention the GIL when calling without a thread state on the free-threaded build #127315

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
63b9772
Improve error message for a NULL tstate on the free-threaded build.
ZeroIntensity Nov 27, 2024
de0e446
Add blurb
ZeroIntensity Nov 27, 2024
2f53c94
Update the tests.
ZeroIntensity Nov 27, 2024
55ffc32
Improve obmalloc error message.
ZeroIntensity Nov 27, 2024
571e16f
Fix C API memory tests.
ZeroIntensity Nov 27, 2024
b2c0dfc
Update obmalloc.c
ZeroIntensity Dec 2, 2024
2d69259
Clarify “it”
ZeroIntensity Dec 2, 2024
bcdf157
Fix the test
ZeroIntensity Dec 2, 2024
d59d134
Remove parens in test
ZeroIntensity Dec 2, 2024
55fafed
Add missing period
ZeroIntensity Dec 2, 2024
910a204
Update pycore_pystate.h
ZeroIntensity Dec 3, 2024
4999bbf
Match the test
ZeroIntensity Dec 3, 2024
3bb19a5
Add missing prefix
ZeroIntensity Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix C API memory tests.
  • Loading branch information
@ZeroIntensity
ZeroIntensity committed Nov 27, 2024
commit 571e16f4e77b23eea2624d345418482acbe00d66
9 changes: 7 additions & 2 deletions Lib/test/test_capi/test_mem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,13 @@ def test_api_misuse(self):

def check_malloc_without_gil(self, code):
out = self.check(code)
expected = ('Fatal Python error: _PyMem_DebugMalloc: '
'Python memory allocator called without holding the GIL')
if not support.Py_GIL_DISABLED:
expected = ('Fatal Python error: _PyMem_DebugMalloc: '
'Python memory allocator called without holding the GIL')
else:
expected = ('Fatal Python error: _PyMem_DebugMalloc: '
'Python memory allocator called without an active thread state. '
'(Are you trying to call it inside of a Py_BEGIN_ALLOW_THREADS block?)')
self.assertIn(expected, out)

def test_pymem_malloc_without_gil(self):
Expand Down