add missing gc_collect() calls in sqlite3 tests #127446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlend-aasland
approved these changes
Nov 30, 2024
serhiy-storchaka
approved these changes
Nov 30, 2024
It's also needed for all other Python implementations that don't use reference counting (GraalPy, for example). Also CPython is moving in the general direction of having less timely finalization (e.g. with deferred refcounting). So I don't think a comment that this is only for pypy is that helpful. |
|
Thanks @cfbolz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 2, 2024
(cherry picked from commit 2a373da) Co-authored-by: CF Bolz-Tereick <[email protected]>
|
GH-127500 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 2, 2024
(cherry picked from commit 2a373da) Co-authored-by: CF Bolz-Tereick <[email protected]>
|
GH-127501 is a backport of this pull request to the 3.12 branch. |
Yhg1s
pushed a commit
that referenced
this pull request
Dec 2, 2024
…127501) add missing gc_collect() calls in sqlite3 tests (GH-127446) (cherry picked from commit 2a373da) Co-authored-by: CF Bolz-Tereick <[email protected]>
Yhg1s
pushed a commit
that referenced
this pull request
Dec 2, 2024
…127500) add missing gc_collect() calls in sqlite3 tests (GH-127446) (cherry picked from commit 2a373da) Co-authored-by: CF Bolz-Tereick <[email protected]>
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyPy needs a
gc_collect()call after thedel curstatements for the cursors' finalizers to execute.