Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-127529: Correct asyncio.selector_events.BaseSelectorEventLoop._accept_connection's behaviour for handling ConnectionAbortedError #127532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 7 commits into from
Jan 3, 2025
+36 −3
Merged

gh-127529: Correct asyncio.selector_events.BaseSelectorEventLoop._accept_connection's behaviour for handling ConnectionAbortedError #127532

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7ab3149
Fix gh-127529: Correct asyncio.selector_events.BaseSelectorEventLoop.…
jb2170 Dec 2, 2024
00f8fa3
Add NEWS article
jb2170 Dec 2, 2024
0f05a32
Remove :func:/:meth: from news article; doc checks don't like it for …
jb2170 Dec 2, 2024
317923d
Add BaseSelectorEventLoopTests.test_accept_connection_skip_connection…
jb2170 Dec 29, 2024
94afe3e
Update Lib/test/test_asyncio/test_selector_events.py
kumaraditya303 Jan 3, 2025
8182a2a
Update Misc/NEWS.d/next/Library/2024-12-02-19-13-19.gh-issue-127529.P…
kumaraditya303 Jan 3, 2025
651cdd9
Update Misc/NEWS.d/next/Library/2024-12-02-19-13-19.gh-issue-127529.P…
kumaraditya303 Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix gh-127529: Correct asyncio.selector_events.BaseSelectorEventLoop.… 
…_accept_connection's behaviour for handling ConnectionAbortedError
  • Loading branch information
@jb2170
jb2170 committed Dec 2, 2024
commit 7ab314941e3d02b681207b4bb655c9697481507f
10 changes: 7 additions & 3 deletions Lib/asyncio/selector_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,13 @@ def _accept_connection(
logger.debug("%r got a new connection from %r: %r",
server, addr, conn)
conn.setblocking(False)
except (BlockingIOError, InterruptedError, ConnectionAbortedError):
# Early exit because the socket accept buffer is empty.
return None
except ConnectionAbortedError:
# Discard connections that were aborted before accept().
continue
except (BlockingIOError, InterruptedError):
# Early exit because of a signal or
# the socket accept buffer is empty.
return
except OSError as exc:
# There's nowhere to send the error, so just log it.
if exc.errno in (errno.EMFILE, errno.ENFILE,
Expand Down