Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-128035: Add ssl.HAS_PHA to detect libssl PHA support #128036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 9 commits into from
Dec 24, 2024
Merged

gh-128035: Add ssl.HAS_PHA to detect libssl PHA support #128036

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7293bec
Add ssl.HAS_PHA to detect libssl PHA support
WillChilds-Klein Dec 17, 2024
9543715
📜🤖 Added by blurb_it.
blurb-it[bot] Dec 17, 2024
0c8f5dd
Update Doc/library/ssl.rst
WillChilds-Klein Dec 17, 2024
fcb7190
Fix news lint
WillChilds-Klein Dec 17, 2024
f7850fd
Update Doc/library/ssl.rst
WillChilds-Klein Dec 17, 2024
57ce78f
Update Lib/test/test_httplib.py
WillChilds-Klein Dec 17, 2024
65e6a0d
Shorten news entry, update whatsnew
WillChilds-Klein Dec 17, 2024
63df081
Move whatsnew section
WillChilds-Klein Dec 17, 2024
a3548a8
Fix whatsnew formatting
WillChilds-Klein Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix news lint
  • Loading branch information
@WillChilds-Klein
WillChilds-Klein committed Dec 18, 2024
commit fcb7190187183464e207b092280360b108a436b2
2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/Core_and_Builtins/2024-12-17-18-20-37.gh-issue-128035.JwqHdB.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
TLSv1.3 post-handshake client authentication (PHA), often referred to as "mutual TLS" or "mTLS", allows TLS servers to authenticate client identities using digital certificates. This commit exposes a boolean property `ssl.HAS_PHA` to indicate whether the crypto library CPython is built against supports PHA, allowing python's test suite and consuming modules to branch accordingly.
TLSv1.3 post-handshake client authentication (PHA), often referred to as "mutual TLS" or "mTLS", allows TLS servers to authenticate client identities using digital certificates. This commit exposes a boolean property ``ssl.HAS_PHA`` to indicate whether the crypto library CPython is built against supports PHA, allowing python's test suite and consuming modules to branch accordingly.
Copy link
Copy Markdown
Member

@picnixz picnixz Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A shorter NEWS should be written. The NEWS is a message that users will see (it's in the changelog). Some suggestion:

Indicate through :data:`ssl.HAS_PHA` whether the :mod:`ssl` module supports TLSv1.3
post-handshake client authentication (PHA). Patch by YOURNAME.

In addition, you should add a What's New entry in Doc/whatsnew/3.14.rst indicating the additional constant. Usually, the same message as for the NEWS entry can be reused (check the other entries for the formatting).

Copy link
Copy Markdown
Contributor Author

@WillChilds-Klein WillChilds-Klein Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the guidance. I've updated the news and whatsnew files accordingly.