Apply suggestions from code review

Co-authored-by: Bénédikt Tran <[email protected]>
python · encukou · Jan 13, 2025 · Jan 4, 2025 · Jan 4, 2025 · Jan 4, 2025
commit 9f272d94a848ab109322477e2a82cfeb5bd5ac2f
diff --git a/Doc/library/ctypes.rst b/Doc/library/ctypes.rst
@@ -872,15 +872,17 @@ invalid non-\ ``NULL`` pointers would crash Python)::
 
 .. _ctypes-thread-safety:
 
-Thread Safety Without The GIL
+Thread safety without the GIL
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 In Python 3.13, the :term:`GIL` may be disabled on :term:`experimental free threaded <free threading>` builds.
-In ctypes, reads and writes to a single object concurrently is safe, but not across multiple objects.::
+In ctypes, reads and writes to a single object concurrently is safe, but not across multiple objects:
 
-   >>> number = c_int(42)
-   >>> pointer_a = pointer(number)
-   >>> pointer_b = pointer(number)
+   .. code-block:: pycon
+
+      >>> number = c_int(42)
+      >>> pointer_a = pointer(number)
+      >>> pointer_b = pointer(number)
 
 In the above, it's only safe for one object to read and write to the address at once if the :term:`GIL` is disabled.
 So, ``pointer_a`` can be shared and written to across multiple threads, but only if ``pointer_b``
@@ -898,7 +900,7 @@ to synchronize access to memory.::
 
 .. seealso::
 
-    :func:`sys._is_gil_enabled` if you would like to dynamically synchronize your application.
+    Use :func:`sys._is_gil_enabled` to dynamically synchronize your application.
 
 .. _ctypes-type-conversions:
 

diff --git a/Lib/test/test_ctypes/test_arrays.py b/Lib/test/test_ctypes/test_arrays.py
@@ -280,7 +280,8 @@ def run():
                 buffer[0] = b"j"
 
         with threading_helper.catch_threading_exception() as cm:
-            with threading_helper.start_threads((Thread(target=run) for _ in range(25))):
+            threads = (Thread(target=run) for _ in range(25))
+            with threading_helper.start_threads(threads):
                 pass
 
             self.assertIsNone(cm.exc_value)

diff --git a/Modules/_ctypes/ctypes.h b/Modules/_ctypes/ctypes.h
@@ -562,15 +562,15 @@ static inline void
 locked_memcpy_to(CDataObject *self, void *buf, Py_ssize_t size)
 {
     LOCK_PTR(self);
-    memcpy(self->b_ptr, buf, size);
+    (void)memcpy(self->b_ptr, buf, size);
     UNLOCK_PTR(self);
 }
 
 static inline void
 locked_memcpy_from(void *buf, CDataObject *self, Py_ssize_t size)
 {
     LOCK_PTR(self);
-    memcpy(buf, self->b_ptr, size);
+    (void)memcpy(buf, self->b_ptr, size);
     UNLOCK_PTR(self);
 }