Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-128646: Implement GzipFile.readinto() functions #128647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zware merged 9 commits into from
Mar 8, 2025
Merged

gh-128646: Implement GzipFile.readinto() functions #128647

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2ac657d
gh-128646: Implement GzipFile.readinto() functions
effigies Jan 8, 2025
db7f971
doc: Add news blurb
effigies Jan 8, 2025
ec797d1
Merge branch 'main' into fix/gzipfile-readinto
effigies Jan 15, 2025
5431ada
Merge branch 'main' into fix/gzipfile-readinto
effigies Feb 3, 2025
b2601d4
test: GzipFile.readinto{,1}
effigies Feb 12, 2025
b2faa7f
Merge branch 'main' into fix/gzipfile-readinto
effigies Feb 12, 2025
aa97613
Merge remote-tracking branch 'upstream/main' into fix/gzipfile-readinto
effigies Feb 20, 2025
e9ff55a
rf: Add helper function to check for READ capability
effigies Feb 20, 2025
9ded50d
Merge branch 'main' into fix/gzipfile-readinto
zware Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rf: Add helper function to check for READ capability
  • Loading branch information
@effigies
effigies committed Feb 20, 2025
commit e9ff55a2870680d121dcffc874392924e111e578
26 changes: 11 additions & 15 deletions Lib/gzip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,45 +318,41 @@ def _write_raw(self, data):

return length

def read(self, size=-1):
self._check_not_closed()
def _check_read(self, caller):
if self.mode != READ:
import errno
raise OSError(errno.EBADF, "read() on write-only GzipFile object")
msg = f"{caller}() on write-only GzipFile object"
raise OSError(errno.EBADF, msg)

def read(self, size=-1):
self._check_not_closed()
self._check_read("read")
return self._buffer.read(size)

def read1(self, size=-1):
"""Implements BufferedIOBase.read1()

Reads up to a buffer's worth of data if size is negative."""
self._check_not_closed()
if self.mode != READ:
import errno
raise OSError(errno.EBADF, "read1() on write-only GzipFile object")
self._check_read("read1")

if size < 0:
size = io.DEFAULT_BUFFER_SIZE
return self._buffer.read1(size)

def readinto(self, b):
self._check_not_closed()
Comment thread
effigies marked this conversation as resolved.
if self.mode != READ:
import errno
raise OSError(errno.EBADF, "readinto() on write-only GzipFile object")
self._check_read("readinto")
return self._buffer.readinto(b)

def readinto1(self, b):
self._check_not_closed()
if self.mode != READ:
import errno
raise OSError(errno.EBADF, "readinto1() on write-only GzipFile object")
self._check_read("readinto1")
return self._buffer.readinto1(b)

def peek(self, n):
self._check_not_closed()
if self.mode != READ:
import errno
raise OSError(errno.EBADF, "peek() on write-only GzipFile object")
self._check_read("peek")
return self._buffer.peek(n)

@property
Expand Down