-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-129223: Do not allow the compiler to optimise away symbols for debug sections #129225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pablogsal
commented
Jan 23, 2025
•
edited by bedevere-app
bot
Loading
edited by bedevere-app
bot
- Issue: The compiler may optimise away globals with debug offsets #129223
@@ -414,7 +414,11 @@ get_py_runtime(pid_t pid) | |||
static uintptr_t | |||
get_async_debug(pid_t pid) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is to avoid returning NULL without an error set as things under search_map_for_section may return without setting an error.
3bfb5f7
to
170075a
Compare
🤖 New build scheduled with the buildbot fleet by @JacobCoffee for commit bd41fda 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F30617%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
🤖 New build scheduled with the buildbot fleet by @ambv for commit bd41fda 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F30617%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
!buildbot aarch64 Fedora Stable Clang |
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 596a58f 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F30617%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
The |
!buildbot PPC64LE .* Refleaks PR |
🤖 New build scheduled with the buildbot fleet by @ambv for commit 596a58f 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
It's weird that Windows 11 and PPC64LE refleaks buildbots are consistently failing with failures that don't look related to external inspection infrastructure:
Refleaks on all other platforms, including s390x, are clean. At the moment we're treating this as unrelated and we'll be looking at a solution to those failures separately. |