Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[3.12] gh-129345: null check for indent syslogmodule (GH-129348) #129443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yhg1s merged 1 commit into from
Feb 3, 2025
Merged

[3.12] gh-129345: null check for indent syslogmodule (GH-129348) #129443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-129345: null check for indent syslogmodule (GH-129348) 
(cherry picked from commit 25cf79a)

Co-authored-by: Burkov Egor <[email protected]>
  • Loading branch information
@wooffie @miss-islington
wooffie authored and miss-islington committed Jan 29, 2025
commit 46db2069622b239f5a9adc419a9af0b69110a634
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2025-01-28-06-23-59.gh-issue-129345.uOjkML.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix null pointer dereference in :func:`syslog.openlog` when an audit hook raises an exception.
2 changes: 1 addition & 1 deletion Modules/syslogmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ syslog_openlog_impl(PyObject *module, PyObject *ident, long logopt,
}
}
if (PySys_Audit("syslog.openlog", "Oll", ident ? ident : Py_None, logopt, facility) < 0) {
Py_DECREF(ident);
Py_XDECREF(ident);
return NULL;
}

Expand Down