Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update manpage environment variables and command line arguments #129623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Feb 12, 2025

Conversation

stefanor
Copy link
Contributor

@stefanor stefanor commented Feb 3, 2025

We got a bug report in Debian for missing PYTHON_BASIC_REPL documentation

The manpage is a bit out of date from the Sphinx docs, when it comes to environment variables and -X command line options.

Bring it back up to date.

I excluded windows-only options, as manpages are probably not relevant on that platform.

@picnixz
Copy link
Member

picnixz commented Feb 4, 2025

I was searching for an issue to use but unless you want to create one with the same text as in the PR, I think we can skip the issue.

We could create an issue though if we want to communicate that the manpage documentation is now up-to-date but it might be unnecessary.

@picnixz picnixz requested review from AA-Turner and hugovk and removed request for ericsnowcurrently February 4, 2025 09:45
@hugovk
Copy link
Member

hugovk commented Feb 4, 2025

Thanks for the update!

How can I build and view the output of this PR?

@picnixz
Copy link
Member

picnixz commented Feb 4, 2025

Otherwise nroff -man file.man | more -s (maybe groff can be used as well)

@picnixz
Copy link
Member

picnixz commented Feb 4, 2025

Oh if you want the full build, I think you need to install entirely, including the docs though I don't remember which target it is. Then use man directly (maybe you need to change some search paths just to avoid getting the manpage of your system-wide python)

Misc/python.man Outdated
Comment on lines 370 to 371
-X gil=[0|1]: enable (1) or disable (0) the GIL; also PYTHON_GIL
Only available in builds configured with --disable-gil.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting this one is shown for python3.14t --help-all and not python3.14 --help-all, but the same applies to PYTHON_GIL and we already have that in this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think we have to include everything (or have multiple manpages).

@stefanor stefanor requested a review from hugovk February 11, 2025 15:01
@hugovk
Copy link
Member

hugovk commented Feb 11, 2025

(Updated from main to fix the change detection we changed recently)

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hugovk hugovk merged commit e1b38ea into python:main Feb 12, 2025
46 checks passed
@hugovk
Copy link
Member

hugovk commented Feb 12, 2025

This has some 3.13-only things, shall we only backport to 3.13? Or also 3.12?

(I won't be surprised if there'll be conflicts anyway for 3.13.)

@stefanor stefanor deleted the envvars-manpage branch February 12, 2025 12:18
@stefanor
Copy link
Contributor Author

I'm happy to review the lists again and prepare backports, if that helps.

@hugovk
Copy link
Member

hugovk commented Feb 13, 2025

Thanks, I don't mind too much either way, let's see if the bot can do the backport for 3.13...

@hugovk hugovk added the needs backport to 3.13 bugs and security fixes label Feb 13, 2025
@miss-islington-app
Copy link

Thanks @stefanor for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 13, 2025
…onGH-129623)

(cherry picked from commit e1b38ea)

Co-authored-by: Stefano Rivera <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 13, 2025

GH-130078 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 13, 2025
@hugovk
Copy link
Member

hugovk commented Feb 13, 2025

It worked!

stefanor added a commit to stefanor/cpython that referenced this pull request Feb 13, 2025
hugovk added a commit that referenced this pull request Feb 13, 2025
hugovk added a commit that referenced this pull request Feb 14, 2025
Co-authored-by: Hugo van Kemenade <[email protected]>
stefanor added a commit to stefanor/cpython that referenced this pull request May 9, 2025
This corrects a mistake I made, when sorting environment variables in
pythonGH-129623.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants