Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-100239: replace BINARY_SUBSCR & family by BINARY_OP with oparg NB_SUBSCR #129700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iritkatriel merged 17 commits into from
Feb 7, 2025
Merged

gh-100239: replace BINARY_SUBSCR & family by BINARY_OP with oparg NB_SUBSCR #129700

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
b7c4f7d
gh-100239: reorganize binary op specs into one table
iritkatriel Jan 30, 2025
9c3ae3f
BINARY_SUBSCR --> BINARY_OP/NB_SUBSCR
iritkatriel Feb 3, 2025
a5af6da
update test
iritkatriel Feb 4, 2025
c809697
fix crash
iritkatriel Feb 4, 2025
d9b0d1b
merge specialize_binary_op_subscr into _Py_Specialize_BinaryOp and bi…
iritkatriel Feb 5, 2025
bd30d28
regen
iritkatriel Feb 5, 2025
c05e483
update ignored.tsv
iritkatriel Feb 5, 2025
dda3d1f
sort out stats
iritkatriel Feb 6, 2025
2cdee79
Merge remote-tracking branch 'upstream/main' into binary_subscr_to_op
iritkatriel Feb 7, 2025
63979ee
Merge remote-tracking branch 'upstream/main' into binary_subscr_to_op
iritkatriel Feb 7, 2025
0fed9ae
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 7, 2025
95fb6dc
docs
iritkatriel Feb 7, 2025
636c8e1
Merge branch 'main' into binary_subscr_to_op
iritkatriel Feb 7, 2025
99173b9
pacify lint
iritkatriel Feb 7, 2025
cfbd6ca
Merge remote-tracking branch 'upstream/main' into binary_subscr_to_op
iritkatriel Feb 7, 2025
091d5e2
Merge remote-tracking branch 'upstream/main' into binary_subscr_to_op
iritkatriel Feb 7, 2025
db143ba
fix doc error
iritkatriel Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update test
  • Loading branch information
@iritkatriel
iritkatriel committed Feb 5, 2025
commit a5af6dad3ed4834e53ce3546c78bb35ce9daf9e8
7 changes: 5 additions & 2 deletions Lib/test/test_peepholer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import dis
from itertools import combinations, product
import opcode
import sys
import textwrap
import unittest
Expand Down Expand Up @@ -517,13 +518,15 @@ def test_folding_subscript(self):
('("a" * 10)[10]', True),
('(1, (1, 2))[2:6][0][2-1]', True),
]
subscr_argval = 26
assert opcode._nb_ops[subscr_argval][0] == 'NB_SUBSCR'
for expr, has_error in tests:
with self.subTest(expr=expr, has_error=has_error):
code = compile(expr, '', 'single')
if not has_error:
self.assertNotInBytecode(code, 'BINARY_SUBSCR')
self.assertNotInBytecode(code, 'BINARY_OP', argval=subscr_argval)
else:
self.assertInBytecode(code, 'BINARY_SUBSCR')
self.assertInBytecode(code, 'BINARY_OP', argval=subscr_argval)
self.check_lnotab(code)

def test_in_literal_list(self):
Expand Down