Change PyBytesWriter_WriteBytes() argument type to void*

python · vstinner · Feb 3, 2025 · Feb 13, 2025 · Feb 14, 2025 · Feb 14, 2025
commit c4f4c07c1259091c1904d0b86548b8e62eaa3509
diff --git a/Include/cpython/bytesobject.h b/Include/cpython/bytesobject.h
@@ -65,7 +65,7 @@ PyAPI_FUNC(void*) PyBytesWriter_Extend(
 PyAPI_FUNC(void*) PyBytesWriter_WriteBytes(
     PyBytesWriter *writer,
     void *buf,
-    const char *bytes,
+    const void *bytes,
     Py_ssize_t size);
 PyAPI_FUNC(void*) PyBytesWriter_Format(
     PyBytesWriter *writer,

diff --git a/Modules/_testcapi/bytes.c b/Modules/_testcapi/bytes.c
@@ -254,6 +254,8 @@ static PyType_Spec Writer_spec = {
 };
 
 
+// Similar to bytes.center() with a different API: spaces are number of
+// whitespaces added to the left and to the right.
 static PyObject *
 byteswriter_center_example(Py_ssize_t spaces, char *str, Py_ssize_t str_size)
 {

diff --git a/Objects/bytesobject.c b/Objects/bytesobject.c
@@ -3675,7 +3675,7 @@ PyBytesWriter_Extend(PyBytesWriter *writer, void *buf, Py_ssize_t extend)
 
 void*
 PyBytesWriter_WriteBytes(PyBytesWriter *writer, void *buf,
-                         const char *bytes, Py_ssize_t size)
+                         const void *bytes, Py_ssize_t size)
 {
     if (size < 0) {
         size = strlen(bytes);