-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-129892: Doc: Remove unnecessary role directive in graphlib.py #129896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change :exec:`ValueError` to ValueError in TopologicalSorter.done() docstring
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
No need for merging main into your branch if nothing has changed and if the CI is not failing (or if the CI jobs were changed on main, usually you need to merge it again). |
This looks like a bug / typo in the docs, so I propose to backport this change. |
Thanks @nikolasavic3 for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
pythonGH-129896) Change `:exec:ValueError` to `ValueError` in `TopologicalSorter.done()` docstring (cherry picked from commit c537301) Co-authored-by: Nikola Savic <[email protected]>
GH-129904 is a backport of this pull request to the 3.13 branch. |
pythonGH-129896) Change `:exec:ValueError` to `ValueError` in `TopologicalSorter.done()` docstring (cherry picked from commit c537301) Co-authored-by: Nikola Savic <[email protected]>
GH-129905 is a backport of this pull request to the 3.12 branch. |
Congrats on your first merged PR :) |
Thank you! :) |
Yes, I forgot to apply the labels, so thank you! |
|
Remove :exec: role directive from ValueError in TopologicalSorter.done() docstring since docstrings are not processed as reST contents.
Fixes #129892
graphlib.py
#129892