Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-130004: Revert commit 9e52e55 #130005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2025
Merged

gh-130004: Revert commit 9e52e55 #130005

merged 1 commit into from
Feb 11, 2025

Conversation

Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Feb 11, 2025 •
edited by bedevere-app bot
Loading

@Fidget-Spinner Fidget-Spinner requested review from a team and markshannon as code owners February 11, 2025 14:29
@bedevere-app bedevere-app bot mentioned this pull request Feb 11, 2025
Closed
@Fidget-Spinner Fidget-Spinner requested review from mdboom and hugovk and removed request for a team and markshannon February 11, 2025 14:29
@Yhg1s
Copy link
Member

Yhg1s commented Feb 11, 2025

For reference (and cross-referencing): this reverts PR #129263.

@StanFromIreland
Copy link
Contributor

This PR was one off the numbers aligning :-(!

@Fidget-Spinner Fidget-Spinner requested a review from ambv February 11, 2025 15:13
@zooba
Copy link
Member

zooba commented Feb 11, 2025

Change looks fine to me.

If we know the value of _MSC_VER where the fix was added, we could make that part of the condition.

@Fidget-Spinner
Copy link
Member Author

Change looks fine to me.

If we know the value of _MSC_VER where the fix was added, we could make that part of the condition.

Let's leave that till after so the release isn't blocked.

@mdboom
Copy link
Contributor

mdboom commented Feb 11, 2025

If we know the value of _MSC_VER where the fix was added, we could make that part of the condition.

I'm trying to determine that -- we use the preview compiler internally for our benchmarking and it's fixed there, but I'll try to determine the non-preview release it shipped on. @zooba: I'll send you the (private) bug link and maybe you understand how to follow the breadcrumbs...

@Fidget-Spinner Fidget-Spinner merged commit 247b50d into python:main Feb 11, 2025
53 checks passed
@Fidget-Spinner Fidget-Spinner deleted the revert-129263 branch February 11, 2025 15:24
@Fidget-Spinner Fidget-Spinner mentioned this pull request Feb 12, 2025
Merged
zanieb added a commit to astral-sh/python-build-standalone that referenced this pull request Feb 12, 2025
@zanieb
Apply the patches from python/cpython#130005 too
931f432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@mdboom mdboom Awaiting requested review from mdboom

@ambv ambv Awaiting requested review from ambv

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Fidget-Spinner @Yhg1s @StanFromIreland @zooba @mdboom @hugovk