Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-82987: Stop on calling frame unconditionally for inline breakpoints #130493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaogaotiantian merged 6 commits into from
Mar 4, 2025
+38 −3
Merged

gh-82987: Stop on calling frame unconditionally for inline breakpoints #130493

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
37b3d29
Stop on calling frame unconditionally for inline breakpoints
gaogaotiantian Feb 24, 2025
6716ac0
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 24, 2025
c6947d1
Update Lib/bdb.py
gaogaotiantian Feb 24, 2025
e8c7d66
Update Misc/NEWS.d/next/Library/2025-02-24-01-49-11.gh-issue-82987.vH…
gaogaotiantian Mar 3, 2025
2cda74c
Add version change in pdb and add whatsnew entry
gaogaotiantian Mar 3, 2025
418e7b1
Update description
gaogaotiantian Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add version change in pdb and add whatsnew entry
  • Loading branch information
@gaogaotiantian
gaogaotiantian committed Mar 3, 2025
commit 2cda74ce3ae831d824ba9aa3c9c583fb39340b81
3 changes: 3 additions & 0 deletions Doc/library/pdb.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,9 @@ access further features, you have to do this yourself:
.. versionadded:: 3.14
Added the *mode* argument.

.. versionchanged:: 3.14
*skip* will be ignored if inline breakpoints like :func:`breakpoint` or :func:`set_trace` are used.
Copy link
Copy Markdown
Member

@iritkatriel iritkatriel Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"if ... are used" could be misunderstood to mean that skip will always be ignored if those are ever used.

Copy link
Copy Markdown
Member Author

@gaogaotiantian gaogaotiantian Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will changing it to "when ... are used" better? Or we should just use the longer version from the news entry?

Copy link
Copy Markdown
Member

@iritkatriel iritkatriel Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "when .. are used" has the same problem, as does the longer version from the news entry.

Copy link
Copy Markdown
Member Author

@gaogaotiantian gaogaotiantian Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Inline breakpoints like :func:`breakpoint` or :func:`pdb.set_trace` will always stop the program at calling frame, ignoring the ``skip`` pattern (if any).

Is this better?

Copy link
Copy Markdown
Member

@iritkatriel iritkatriel Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Copy link
Copy Markdown
Member Author

@gaogaotiantian gaogaotiantian Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I'll use this for all 3 places :)


.. method:: run(statement, globals=None, locals=None)
runeval(expression, globals=None, locals=None)
runcall(function, *args, **kwds)
Expand Down
5 changes: 5 additions & 0 deletions Doc/whatsnew/3.14.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,6 +709,11 @@ pdb
the quit and call :func:`sys.exit`, instead of raising :exc:`bdb.BdbQuit`.
(Contributed by Tian Gao in :gh:`124704`.)

* :mod:`pdb` will always stop on calling frames when inline breakpoints like
:func:`breakpoint` or :func:`pdb.set_trace` are used, ignoring the ``skip``
pattern (if any).
(Contributed by Tian Gao in :gh:`130493`.)


pickle
------
Expand Down