Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-127785: Limit check labels github action permission #130596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

shenxianpeng
Copy link
Contributor

@shenxianpeng shenxianpeng commented Feb 26, 2025

The workflow checks for labels on pull requests using the mheap/github-action-required-labels action. Since this action only reads PR labels without modifying them, it does not require write permissions.

I tested it in my test-repo/pull/11, removed issues: write and changed pull-requests: write to pull-requests: read to limit permissions, The workflow functioned as expected.

@ghost
Copy link

ghost commented Feb 26, 2025

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Feb 26, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@AA-Turner AA-Turner merged commit 5ba69e7 into python:main Feb 26, 2025
46 checks passed
@hugovk hugovk added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Feb 26, 2025
@miss-islington-app
Copy link

Thanks @shenxianpeng for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @shenxianpeng for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @shenxianpeng and @AA-Turner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5ba69e747fa9da984a307b2cbc9f82bac1e0db04 3.13

@miss-islington-app
Copy link

Sorry, @shenxianpeng and @AA-Turner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5ba69e747fa9da984a307b2cbc9f82bac1e0db04 3.12

@shenxianpeng shenxianpeng deleted the update-github-action-permission branch February 27, 2025 01:22
@hugovk
Copy link
Member

hugovk commented Feb 27, 2025

@shenxianpeng Please could you take care of the backports? Thanks!

shenxianpeng added a commit to shenxianpeng/cpython that referenced this pull request Feb 27, 2025
shenxianpeng added a commit to shenxianpeng/cpython that referenced this pull request Feb 27, 2025
…flow (pythonGH-130596)

(cherry picked from commit 5ba69e7)

Co-authored-by: shenxianpeng <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 27, 2025

GH-130623 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 27, 2025
@bedevere-app
Copy link

bedevere-app bot commented Feb 27, 2025

GH-130623 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 27, 2025
@bedevere-app
Copy link

bedevere-app bot commented Feb 27, 2025

GH-130624 is a backport of this pull request to the 3.12 branch.

@bedevere-app
Copy link

bedevere-app bot commented Feb 27, 2025

GH-130625 is a backport of this pull request to the 3.12 branch.

@shenxianpeng
Copy link
Contributor Author

@shenxianpeng Please could you take care of the backports? Thanks!

Sure, I've already taken care of the backports.

hugovk pushed a commit that referenced this pull request Feb 27, 2025
hugovk pushed a commit that referenced this pull request Feb 27, 2025
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants