Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-130396: Fix thread sanitizer crashes on stack overflow tests #130966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 1 commit into from
Mar 11, 2025
Merged

gh-130396: Fix thread sanitizer crashes on stack overflow tests #130966

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-130396: Fix thread sanitizer crashes on stack overflow tests 
Thread sanitizer will often crash if a test uses more than half the
stack.
  • Loading branch information
@colesbury
colesbury committed Mar 7, 2025
commit 5dadae5dfecd28e52fb6a6c87f7903590ec39a6d
5 changes: 5 additions & 0 deletions Python/ceval.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,12 @@ _Py_InitializeRecursionLimits(PyThreadState *tstate)
if (err == 0) {
uintptr_t base = ((uintptr_t)stack_addr) + guard_size;
_tstate->c_stack_top = base + stack_size;
#ifdef _Py_THREAD_SANITIZER
// Thread sanitizer crashes if we use a bit more than half the stack.
_tstate->c_stack_soft_limit = base + (stack_size / 2);
#else
_tstate->c_stack_soft_limit = base + PYOS_STACK_MARGIN_BYTES * 2;
#endif
_tstate->c_stack_hard_limit = base + PYOS_STACK_MARGIN_BYTES;
assert(_tstate->c_stack_soft_limit < here_addr);
assert(here_addr < _tstate->c_stack_top);
Expand Down
Loading