attempted fix of issue #131116. Test case failing on non changed parts

python · serhiy-storchaka · Nov 12, 2025 · Mar 12, 2025 · Mar 12, 2025 · Mar 12, 2025
commit 19d5c42b09a57c5d93ee9cd391ab21b8ea55ba90
diff --git a/Lib/inspect.py b/Lib/inspect.py
@@ -747,6 +747,12 @@ def _finddoc(obj):
         cls = _findclass(obj.fget)
         if cls is None or getattr(cls, name) is not obj:
             return None
+    # Should be tested before ismethoddescriptor()
+    elif isinstance(obj, functools.cached_property):
+        name = obj.attrname
+        cls = _findclass(obj.func)
+        if cls is None or getattr(cls, name) is not obj:
+            return None
     elif ismethoddescriptor(obj) or isdatadescriptor(obj):
         name = obj.__name__
         cls = obj.__objclass__

diff --git a/Lib/test/test_inspect/inspect_fodder.py b/Lib/test/test_inspect/inspect_fodder.py
@@ -2,6 +2,7 @@
 'A module docstring.'
 
 import inspect
+from functools import cached_property
 # line 5
 
 # line 7
@@ -50,6 +51,11 @@ def contradiction(self):
         'The automatic gainsaying.'
         pass
 
+    @cached_property
+    def foo(self):
+        "StupidGit.foo docstring"
+        pass
+
 # line 53
 class MalodorousPervert(StupidGit):
     def abuse(self, a, b, c):
@@ -59,6 +65,10 @@ def abuse(self, a, b, c):
     def contradiction(self):
         pass
 
+    @cached_property
+    def foo(self):
+        pass
+
 Tit = MalodorousPervert
 
 class ParrotDroppings:

diff --git a/Lib/test/test_inspect/test_inspect.py b/Lib/test/test_inspect/test_inspect.py
@@ -652,6 +652,9 @@ def test_getdoc(self):
                          'measured in kilowatts')
         self.assertEqual(inspect.getdoc(SlotUser.distance),
                          'measured in kilometers')
+        print('new test', file=sys.stderr)
+        self.assertEqual(inspect.getdoc(mod.MalodorousPervert.foo),
+                         inspect.getdoc(mod.StupidGit.foo))
 
     @unittest.skipIf(sys.flags.optimize >= 2,
                      "Docstrings are omitted with -O2 and above")