Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-90548: Make musl test skips smarter (fixes Alpine errors) #131313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bitdancer merged 9 commits into from
Mar 19, 2025
Merged

gh-90548: Make musl test skips smarter (fixes Alpine errors) #131313

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2348711
Make musl test skips smarter (fixes Alpine errors)
bitdancer Mar 15, 2025
35960c1
Platform tests and bug fixes.
bitdancer Mar 15, 2025
417143e
Add docs, including some existing is_xxx's.
bitdancer Mar 15, 2025
ef36eb2
Address vstinner review comments.
bitdancer Mar 17, 2025
909ea3b
Test some version number variants we accept.
bitdancer Mar 17, 2025
4e76d78
Add news item about libc_ver enhancement.
bitdancer Mar 17, 2025
83add5d
Fix 'in' phrase logic.
bitdancer Mar 18, 2025
4d6aa92
Prettify re expression using re.VERBOSE.
bitdancer Mar 18, 2025
111e2ec
Use more verbose style rather than :=
bitdancer Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix 'in' phrase logic. 
This didn't cause a test failure because the broken logic caused the
regex to always run...which is a lot slower.
  • Loading branch information
@bitdancer
bitdancer committed Mar 18, 2025
commit 83add5d6fc37d4b6a981d497f6a5783997257913
2 changes: 1 addition & 1 deletion Lib/platform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ def libc_ver(executable=None, lib='', version='', chunksize=16384):
binary = f.read(chunksize)
pos = 0
while pos < len(binary):
if b'libc' in binary or b'GLIBC' or 'musl' in binary:
if b'libc' in binary or b'GLIBC' in binary or b'musl' in binary:
m = libc_search.search(binary, pos)
else:
m = None
Expand Down